mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang@gmail.com>
To: Corey Minyard <minyard@acm.org>
Cc: Geliang Tang <geliangtang@gmail.com>,
	openipmi-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ipmi_ssif: use setup_timer
Date: Fri, 24 Mar 2017 22:15:12 +0800	[thread overview]
Message-ID: <c76d166d783a5f16945ec74549965917f97ff738.1490341846.git.geliangtang@gmail.com> (raw)
In-Reply-To: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com>

Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/char/ipmi/ipmi_ssif.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index cca6e5b..a92a049 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1642,9 +1642,8 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id)
 
 	spin_lock_init(&ssif_info->lock);
 	ssif_info->ssif_state = SSIF_NORMAL;
-	init_timer(&ssif_info->retry_timer);
-	ssif_info->retry_timer.data = (unsigned long) ssif_info;
-	ssif_info->retry_timer.function = retry_timeout;
+	setup_timer(&ssif_info->retry_timer, retry_timeout,
+		    (unsigned long)ssif_info);
 
 	for (i = 0; i < SSIF_NUM_STATS; i++)
 		atomic_set(&ssif_info->stats[i], 0);
-- 
2.9.3

  parent reply	other threads:[~2017-03-24 14:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 14:15 [PATCH] aoe: " Geliang Tang
2017-03-24 14:15 ` [PATCH] block: floppy: " Geliang Tang
2017-03-24 14:23   ` Jens Axboe
2017-03-24 14:15 ` [PATCH] drbd: " Geliang Tang
2017-03-24 14:15 ` Geliang Tang [this message]
2017-03-25  2:59   ` [PATCH] ipmi_ssif: " Corey Minyard
2017-03-24 14:15 ` [PATCH] mg_disk: " Geliang Tang
2017-03-24 14:15 ` [PATCH] x86/pci-calgary: " Geliang Tang
2017-03-31  8:24   ` [tip:x86/cleanups] x86/pci-calgary: Use setup_timer() instead of open coding it tip-bot for Geliang Tang
2017-03-25 19:32 ` [PATCH] aoe: use setup_timer Ed Cashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c76d166d783a5f16945ec74549965917f97ff738.1490341846.git.geliangtang@gmail.com \
    --to=geliangtang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®