mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nadav Amit <nadav.amit@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/lib: Do not use local symbols with SYM_CODE_START_LOCAL()
Date: Thu, 5 Jan 2023 12:33:54 -0800	[thread overview]
Message-ID: <48498199-175D-467B-942B-9F8A923B8930@gmail.com> (raw)
In-Reply-To: <20221122071547.165296-1-namit@vmware.com>



> On Nov 21, 2022, at 11:15 PM, Nadav Amit <nadav.amit@gmail.com> wrote:
> 
> From: Nadav Amit <namit@vmware.com>
> 
> When SYM_CODE_START_LOCAL() is used, the symbols are local but should be
> saved to the object. In contrast, using ".L" label prefix causes the
> symbols not to be saved in the object.
> 
> Since it is preferable to be able to map instruction pointers back to
> symbols, the local symbol should be saved in the object. Therefore, when
> SYM_CODE_START_LOCAL() is used, the ".L" label prefix should not be
> used.
> 
> Two symbols, however, have both SYM_CODE_START_LOCAL() and ".L" prefix:
> .Lbad_put_user_clac and .Lcopy_user_handle_tail. Remove the ".L" prefix
> from them.
> 
> No functional change, other then emitting these symbols into the object,
> is intended.
> 
> Signed-off-by: Nadav Amit <namit@vmware.com>

Ping.



      reply	other threads:[~2023-01-05 20:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  7:15 Nadav Amit
2023-01-05 20:33 ` Nadav Amit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48498199-175D-467B-942B-9F8A923B8930@gmail.com \
    --to=nadav.amit@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®