mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/omap: omap_display_timings: constify videomode structures
@ 2017-08-04  6:09 Julia Lawall
  2017-08-04  9:37 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2017-08-04  6:09 UTC (permalink / raw)
  To: Tomi Valkeinen
  Cc: kernel-janitors, David Airlie, dri-devel, linux-kernel, Bhumika Goyal

The videomode structures are only copied into the vm field of a
panel_drv_data structure, so they can be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |    2 +-
 drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
index c90474a..74d1396 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
@@ -19,7 +19,7 @@
 
 #include "../dss/omapdss.h"
 
-static struct videomode lb035q02_vm = {
+static const struct videomode lb035q02_vm = {
 	.hactive = 320,
 	.vactive = 240,
 
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
index cbf4c67..0a38a0e 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
@@ -40,7 +40,7 @@ struct panel_drv_data {
 	struct spi_device *spi_dev;
 };
 
-static struct videomode td028ttec1_panel_vm = {
+static const struct videomode td028ttec1_panel_vm = {
 	.hactive	= 480,
 	.vactive	= 640,
 	.pixelclock	= 22153000,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/omap: omap_display_timings: constify videomode structures
  2017-08-04  6:09 [PATCH] drm/omap: omap_display_timings: constify videomode structures Julia Lawall
@ 2017-08-04  9:37 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2017-08-04  9:37 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kernel-janitors, David Airlie, dri-devel, linux-kernel, Bhumika Goyal


[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]

On 04/08/17 09:09, Julia Lawall wrote:
> The videomode structures are only copied into the vm field of a
> panel_drv_data structure, so they can be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |    2 +-
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-04  9:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04  6:09 [PATCH] drm/omap: omap_display_timings: constify videomode structures Julia Lawall
2017-08-04  9:37 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®