From: Florian Fainelli <f.fainelli@gmail.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_port: Check IRQ data before use
Date: Thu, 31 Aug 2023 16:08:17 -0700 [thread overview]
Message-ID: <48812e7c-1bbf-0084-41be-f62d2cc60231@gmail.com> (raw)
In-Reply-To: <20230831222555.614426-1-andriy.shevchenko@linux.intel.com>
On 8/31/23 15:25, Andy Shevchenko wrote:
> In case the leaf driver wants to use IRQ polling (irq = 0) and
> IIR register shows that an interrupt happened in the 8250 hardware
> the IRQ data can be NULL. In such a case we need to skip the wake
> event as we came to this path from the timer interrupt and quite
> likely system is already awake.
I suppose that is fair to say.
>
> Without this fix we have got an Oops:
>
> serial8250: ttyS0 at I/O 0x3f8 (irq = 0, base_baud = 115200) is a 16550A
> ...
> BUG: kernel NULL pointer dereference, address: 0000000000000010
> RIP: 0010:serial8250_handle_irq+0x7c/0x240
> Call Trace:
> ? serial8250_handle_irq+0x7c/0x240
> ? __pfx_serial8250_timeout+0x10/0x10
>
> Fixes: 0ba9e3a13c6a ("serial: 8250: Add missing wakeup event reporting")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks Andy!
--
Florian
prev parent reply other threads:[~2023-08-31 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 22:25 Andy Shevchenko
2023-08-31 23:08 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48812e7c-1bbf-0084-41be-f62d2cc60231@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®