From: Stefan Wahren <stefan.wahren@i2se.com>
To: Mark Brown <broonie@kernel.org>
Cc: Joe Perches <joe@perches.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH V2] regulator: core: fix constraints debug output
Date: Tue, 9 Jun 2015 20:49:14 +0200 (CEST) [thread overview]
Message-ID: <489276691.38639.1433875754470.JavaMail.open-xchange@oxbsltgw09.schlund.de> (raw)
In-Reply-To: <20150609180028.GT14071@sirena.org.uk>
> Mark Brown <broonie@kernel.org> hat am 9. Juni 2015 um 20:00 geschrieben:
>
>
> On Wed, Jun 03, 2015 at 09:56:29PM +0000, Stefan Wahren wrote:
> > The line buffer for constraints debug isn't big enough to hold the output
> > in all cases. So fix the possible buffer overflow by the usage of the
> > scnprintf().
>
> If we know how much output we might produce then why not extend the
> buffer so we don't need to cut it off? The defensive programming is
> good but that seems a better fix.
I thought the intension was to keep the output in "one" line. If not i suggest
to increase the size to 160 bytes, which is sufficient for all cases.
next prev parent reply other threads:[~2015-06-09 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 21:56 Stefan Wahren
2015-06-09 18:00 ` Mark Brown
2015-06-09 18:49 ` Stefan Wahren [this message]
2015-06-09 18:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489276691.38639.1433875754470.JavaMail.open-xchange@oxbsltgw09.schlund.de \
--to=stefan.wahren@i2se.com \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®