* Re: [PATCH] bnx2x: precedence confusion !x & y
2008-08-09 4:27 [PATCH] bnx2x: precedence confusion !x & y roel kluin
@ 2008-08-08 23:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-08-08 23:20 UTC (permalink / raw)
To: roel.kluin; +Cc: yanivr, eilong, netdev, linux-kernel
From: roel kluin <roel.kluin@gmail.com>
Date: Sat, 09 Aug 2008 00:27:15 -0400
> ! has a higher precedence than &
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
This is already fixed in Linus's tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] bnx2x: precedence confusion !x & y
@ 2008-08-09 4:27 roel kluin
2008-08-08 23:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-08-09 4:27 UTC (permalink / raw)
To: yanivr, eilong, netdev, linux-kernel
! has a higher precedence than &
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index af251a5..272a4bd 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -7202,7 +7202,7 @@ static void __devinit bnx2x_link_settings_requested(struct bnx2x *bp)
bp->link_params.req_flow_ctrl = (bp->port.link_config &
PORT_FEATURE_FLOW_CONTROL_MASK);
if ((bp->link_params.req_flow_ctrl == FLOW_CTRL_AUTO) &&
- (!bp->port.supported & SUPPORTED_Autoneg))
+ !(bp->port.supported & SUPPORTED_Autoneg))
bp->link_params.req_flow_ctrl = FLOW_CTRL_NONE;
BNX2X_DEV_INFO("req_line_speed %d req_duplex %d req_flow_ctrl 0x%x"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-08 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-09 4:27 [PATCH] bnx2x: precedence confusion !x & y roel kluin
2008-08-08 23:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®