mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fix crc-error warning on modules
@ 2005-12-21  2:27 Luke Yang
  0 siblings, 0 replies; only message in thread
From: Luke Yang @ 2005-12-21  2:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Hi all,

   This is the patch for the following issue:

 In include/linux/module.h, "__crc_" and "__ksymtab_" are hard
coded to be the   prefix for some kinds of symbols (CRC symbol and
ksymtab section). But in script /mod/modpost.c,
MODULE_SYMBOL_PREFIX##"__crc_" is used as the prefix to search CRC
symbols. So if an architecture (such as h8300 or Blackfin) defines
MODULE_SYMBOL_PREFIX as not NULL ("_"), modpost will always warn about
"no invalid crc".
  And it is the same with KSYMTAB_PFX.

  Signed-off-by: Luke Yang <luke.adi@gmail.com>

Index: git/linux-2.6/scripts/mod/modpost.c
===================================================================
--- git.orig/linux-2.6/scripts/mod/modpost.c	2005-12-15 11:37:20.000000000 +0800
+++ git/linux-2.6/scripts/mod/modpost.c	2005-12-15 11:49:30.000000000 +0800
@@ -326,8 +326,8 @@
 	release_file(info->hdr, info->size);
 }

-#define CRC_PFX     MODULE_SYMBOL_PREFIX "__crc_"
-#define KSYMTAB_PFX MODULE_SYMBOL_PREFIX "__ksymtab_"
+#define CRC_PFX     "__crc_"
+#define KSYMTAB_PFX "__ksymtab_"

 void
 handle_modversions(struct module *mod, struct elf_info *info,

Best regards,
Luke Yang
Analog Device Inc.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-12-21  2:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-21  2:27 [PATCH] Fix crc-error warning on modules Luke Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®