From: "Jan Beulich" <jbeulich@novell.com>
To: <linux@sandersweb.net>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Andi Kleen" <andi-suse@firstfloor.org>,
"Arjan van de Ven" <arjan@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [BUG] x86 kenel won't boot under Virtual PC
Date: Fri, 05 Sep 2008 17:15:48 +0100 [thread overview]
Message-ID: <48C17754.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200809051138.20615.linux@sandersweb.net>
>--- a/include/asm-x86/nops.h
>+++ b/include/asm-x86/nops.h
>@@ -84,7 +84,7 @@
> #define ASM_NOP6 K7_NOP6
> #define ASM_NOP7 K7_NOP7
> #define ASM_NOP8 K7_NOP8
>-#elif defined(CONFIG_X86_P6_NOP)
>+/* #elif defined(CONFIG_X86_P6_NOP)
> #define ASM_NOP1 P6_NOP1
> #define ASM_NOP2 P6_NOP2
> #define ASM_NOP3 P6_NOP3
>@@ -93,6 +93,7 @@
> #define ASM_NOP6 P6_NOP6
> #define ASM_NOP7 P6_NOP7
> #define ASM_NOP8 P6_NOP8
>+*/
> #elif defined(CONFIG_X86_64)
> #define ASM_NOP1 K8_NOP1
> #define ASM_NOP2 K8_NOP2
I disagree here: If I configure a 686+ kernel, I expect these NOPs to be
that way (and to work). If you want to run on something that's not
compliant, you just shouldn't configure your kernel that way.
Jan
next prev parent reply other threads:[~2008-09-05 16:15 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 18:22 David Sanders
2008-08-31 18:47 ` Linus Torvalds
2008-08-31 19:27 ` Arjan van de Ven
2008-08-31 19:39 ` Linus Torvalds
2008-09-05 15:38 ` David Sanders
2008-09-05 16:15 ` Jan Beulich [this message]
2008-09-05 16:39 ` Linus Torvalds
2008-09-05 18:43 ` Ingo Molnar
2008-09-05 20:06 ` H. Peter Anvin
2008-09-05 19:08 ` Jeremy Fitzhardinge
2008-09-05 20:12 ` H. Peter Anvin
2008-09-05 16:30 ` Linus Torvalds
2008-09-05 17:55 ` Andi Kleen
2008-08-31 20:03 ` David Sanders
2008-09-01 20:23 ` David Sanders
2008-09-01 22:22 ` Linus Torvalds
2008-09-02 12:08 ` David Sanders
2008-09-02 18:12 ` Linus Torvalds
2008-09-02 18:44 ` David Sanders
2008-09-03 11:09 ` Peter Zijlstra
2008-09-03 11:20 ` David Sanders
[not found] ` <48C1C156.9080003@zytor.com>
2008-09-07 20:07 ` David Sanders
2008-09-07 23:22 ` David Sanders
2008-09-08 1:48 ` H. Peter Anvin
2008-09-08 2:49 ` David Sanders
2008-09-08 4:04 ` H. Peter Anvin
2008-09-08 9:42 ` Andi Kleen
2008-09-08 13:25 ` David Sanders
2008-09-08 15:09 ` Linus Torvalds
2008-09-08 15:23 ` Ingo Molnar
2008-09-08 15:36 ` H. Peter Anvin
2008-09-08 15:38 ` David Sanders
2008-09-08 15:38 ` H. Peter Anvin
2008-09-08 15:45 ` Andi Kleen
2008-09-08 15:43 ` H. Peter Anvin
2008-09-08 15:50 ` H. Peter Anvin
2008-09-08 15:50 ` Andi Kleen
2008-09-08 15:50 ` H. Peter Anvin
2008-09-08 15:57 ` Andi Kleen
2008-09-08 15:54 ` H. Peter Anvin
2008-09-08 16:07 ` Linus Torvalds
2008-09-08 16:13 ` H. Peter Anvin
2008-09-08 16:15 ` H. Peter Anvin
2008-09-08 16:26 ` David Sanders
2008-09-08 16:20 ` Linus Torvalds
2008-09-08 16:32 ` H. Peter Anvin
2008-09-08 17:02 ` Ingo Molnar
2008-09-08 16:34 ` david
2008-09-08 16:42 ` H. Peter Anvin
2008-09-08 18:51 ` david
2008-09-08 16:59 ` Linus Torvalds
2008-09-08 17:00 ` Andi Kleen
2008-09-08 17:04 ` Linus Torvalds
2008-09-08 17:08 ` H. Peter Anvin
2008-09-08 17:12 ` H. Peter Anvin
2008-09-08 17:41 ` Linus Torvalds
2008-09-08 17:38 ` Linus Torvalds
2008-09-08 17:59 ` H. Peter Anvin
2008-09-08 19:09 ` H. Peter Anvin
2008-09-08 22:42 ` Linus Torvalds
2008-09-08 17:18 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C17754.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=andi-suse@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sandersweb.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome