mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kenneth Crudup <kenny@panix.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	linux-acpi@vger.kernel.org, linux-media@vger.kernel.org,
	johannes.goede@oss.qualcomm.com,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 1/1] software node: Also support referencing non-constant software nodes
Date: Fri, 19 Dec 2025 12:55:30 -0800	[thread overview]
Message-ID: <48b94c22-c1ca-4220-b184-f38e22544b9d@panix.com> (raw)
In-Reply-To: <20251219083638.2454138-1-sakari.ailus@linux.intel.com>


Apparently last to the party :) but:

Tested-By: Kenneth R. Crudup <kenny@panix.com>

-K

On 12/19/25 00:36, Sakari Ailus wrote:
> Fwnode references are be implemented differently if referenced node is a
> software node. _Generic() is used to differentiate between the two cases
> but only const software nodes were present in the selection. Also add
> non-const software nodes.
> 
> Reported-by: Kenneth Crudup <kenny@panix.com>
> Closes: https://lore.kernel.org/all/af773b82-bef2-4209-baaf-526d4661b7fc@panix.com/
> Fixes: d7cdbbc93c56 ("software node: allow referencing firmware nodes")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Hi Kenneth,
> 
> Many thanks for reporting the issue and bisecting the offending patch!
> Could you confirm whether this fixes the issue (it does for me)?
> 
> - Sakari
> 
>   include/linux/property.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 272bfbdea7bf..e30ef23a9af3 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -371,6 +371,7 @@ struct software_node_ref_args {
>   (const struct software_node_ref_args) {				\
>   	.swnode = _Generic(_ref_,				\
>   			   const struct software_node *: _ref_,	\
> +			   struct software_node *: _ref_,	\
>   			   default: NULL),			\
>   	.fwnode = _Generic(_ref_,				\
>   			   struct fwnode_handle *: _ref_,	\

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange 
County CA


  parent reply	other threads:[~2025-12-19 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <af773b82-bef2-4209-baaf-526d4661b7fc@panix.com>
2025-12-19  8:36 ` Sakari Ailus
2025-12-19 13:13   ` Mehdi Djait
2025-12-19 15:05     ` johannes.goede
2025-12-19 15:11       ` Danilo Krummrich
2025-12-19 15:38         ` johannes.goede
2025-12-19 15:47           ` Danilo Krummrich
2025-12-19 20:55   ` Kenneth Crudup [this message]
2025-12-22 12:36   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48b94c22-c1ca-4220-b184-f38e22544b9d@panix.com \
    --to=kenny@panix.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®