From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Rami Rosen <roszenrami@gmail.com>
Cc: David Miller <davem@davemloft.net>,
charrer@alacritech.com, liodot@gmail.com,
gregkh@linuxfoundation.org, andrew@lunn.ch,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver
Date: Sun, 27 Nov 2016 02:02:27 +0100 [thread overview]
Message-ID: <48c6a5d1-cde3-6e23-9c6c-d26838fce332@gmx.de> (raw)
In-Reply-To: <CAKoUArncMYtQZQZ62efWsXr25RZPiAx4USJFjf2emzVRkhELjg@mail.gmail.com>
Hi Rami,
On 26.11.2016 16:48, Rami Rosen wrote:
>> @@ -0,0 +1,28 @@
>> +config NET_VENDOR_ALACRITECH
>> + bool "Alacritech devices"
>> + default y
>> + ---help---
>> + If you have a network (Ethernet) card belonging to this class, say Y.
>> +
>> + Note that the answer to this question doesn't directly affect the
>> + kernel: saying N will just cause the configurator to skip all
>
> Shouldn't it be "Alacritech devices" here, as appears earlier ?
>
>> + the questions about Renesas devices. If you say Y, you will be asked
Yes, it definitely should not be Renesas :). This is a stupid copy and paste error, I will fix it,
thank you!
>> + for your specific device in the following questions.
>> +
>
> ...
> ...
> ...
>> +struct slic_device {
>> + struct pci_dev *pdev;
> ...
>> + bool promisc;
>
> Seems that the autoneg boolean is not used anywhere, apart from
> setting it once to true in
> the slic_set_link_autoneg() method. Apart from this member it is not
> accessed anywhere, so it seems it should be removed.
>
>> + bool autoneg;
>> + int speed;
Agreed, this variable can be removed.
> ...
>
>> +static int slic_load_rcvseq_firmware(struct slic_device *sdev)
>> +{
>> + const struct firmware *fw;
>> + const char *file;
>> + u32 codelen;
>> + int idx = 0;
>> + u32 instr;
>> + u32 addr;
>> + int err;
>> +
> ...
>> + /* Do an initial sanity check concerning firmware size now. A further
>> + * check follows below.
>> + */
>> + if (fw->size < SLIC_FIRMWARE_MIN_SIZE) {
>> + dev_err(&sdev->pdev->dev,
>> + "invalid firmware size %zu (min %u expected)\n",
>> + fw->size, SLIC_FIRMWARE_MIN_SIZE);
>> + err = -EINVAL;
>
> in the release label, always 0 is returned:
>
>> + goto release;
>> + }
>> +
>> + codelen = slic_read_dword_from_firmware(fw, &idx);
>> +
>> + /* do another sanity check against firmware size */
>> + if ((codelen + 4) > fw->size) {
>> + dev_err(&sdev->pdev->dev,
>> + "invalid rcv-sequencer firmware size %zu\n", fw->size);
>> + err = -EINVAL;
>
> Again, in the release label, always 0 is returned:
>
>> + goto release;
>> + }
>> +
>>
>> +release:
>> + release_firmware(fw);
>> +
>> + return 0;
>> +}
This should return "err", I will fix it.
Thanks a lot for the review!
Regards,
Lino
next prev parent reply other threads:[~2016-11-27 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 12:20 Gigabit ethernet driver for Alacritechs SLIC devices (v3) Lino Sanfilippo
2016-11-26 12:20 ` [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo
2016-11-26 15:48 ` Rami Rosen
2016-11-27 1:02 ` Lino Sanfilippo [this message]
2016-11-27 17:59 ` Markus Böhme
2016-11-28 20:46 ` Lino Sanfilippo
2016-11-29 12:15 ` Markus Böhme
2016-11-28 4:56 ` Florian Fainelli
2016-11-28 21:41 ` Lino Sanfilippo
2016-11-29 17:14 ` Florian Fainelli
2016-11-30 19:48 ` Lino Sanfilippo
2016-12-04 2:13 ` kbuild test robot
2016-11-26 12:20 ` [PATCH v3 net-next 2/2] MAINTAINERS: add entry for slicoss " Lino Sanfilippo
2016-11-26 12:36 ` Gigabit ethernet driver for Alacritechs SLIC devices (v3) Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c6a5d1-cde3-6e23-9c6c-d26838fce332@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=andrew@lunn.ch \
--cc=charrer@alacritech.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®