mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Petr Vorel <pvorel@suse.cz>, linux-kernel@vger.kernel.org
Cc: Simon Glass <sjg@chromium.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH 1/1] checkpatch: Ignore <inttypes.h> format macros
Date: Mon, 11 May 2026 11:54:03 -0700	[thread overview]
Message-ID: <48d091b644b205b1dad326a855d5b766b042c120.camel@perches.com> (raw)
In-Reply-To: <20260511121237.11030-1-pvorel@suse.cz>

On Mon, 2026-05-11 at 14:12 +0200, Petr Vorel wrote:
> ```
> Constants from <inttypes.h> are used only in userspace tools, they are
> from ISO C99, let's don't report it:
> 
>     arch/mips/boot/tools/relocs.c:572: CHECK: Avoid CamelCase: <PRIx32>
>     arch/s390/tools/relocs.c:52: CHECK: Avoid CamelCase: <PRIu64>
>     tools/testing/selftests/mm/vm_util.c:244: CHECK: Avoid CamelCase: <SCNu64>
> 
> Signed-off-by: Petr Vorel <[pvorel@suse.cz](mailto:pvorel@suse.cz)>

Nack.  This is userspace only and should be tested as such.

> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3727156e4ccad..4c7a952a418c0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5940,6 +5940,8 @@ sub process {
>  #Ignore SI style variants like nS, mV and dB
>  #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
>  			    $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
> +#Ignore <inttypes.h> format macros (e.g. PRIu64, SCNu64)
> +			    $var !~ /^(?:PRI|SCN)[dioux][A-Z0-9]+$/ &&
>  #Ignore some three character SI units explicitly, like MiB and KHz
>  			    $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
>  				while ($var =~ m{\b($Ident)}g) {
> 
> ```

  parent reply	other threads:[~2026-05-11 18:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 12:12 Petr Vorel
2026-05-11 13:37 ` Simon Glass
2026-05-11 20:55   ` Petr Vorel
2026-05-11 18:54 ` Joe Perches [this message]
2026-05-11 21:57   ` Petr Vorel
2026-05-11 23:18     ` Joe Perches
2026-05-12 18:20       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48d091b644b205b1dad326a855d5b766b042c120.camel@perches.com \
    --to=joe@perches.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=pvorel@suse.cz \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®