mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-kernel@vger.kernel.org, Simon Glass <sjg@chromium.org>,
	Dwaipayan Ray	 <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH 1/1] checkpatch: Ignore <inttypes.h> format macros
Date: Mon, 11 May 2026 16:18:20 -0700	[thread overview]
Message-ID: <f9e8a6e829c6b7ecba0cc60cacb2c3943e0daf6b.camel@perches.com> (raw)
In-Reply-To: <20260511215757.GB20488@pevik>

On Mon, 2026-05-11 at 23:57 +0200, Petr Vorel wrote:
> On Mon, 2026-05-11 at 14:12 +0200, Petr Vorel wrote:
> > > Constants from <inttypes.h> are used only in userspace tools, they are
> > > from ISO C99, let's don't report it:
> > >     arch/mips/boot/tools/relocs.c:572: CHECK: Avoid CamelCase: <PRIx32>
> > >     arch/s390/tools/relocs.c:52: CHECK: Avoid CamelCase: <PRIu64>
> > >     tools/testing/selftests/mm/vm_util.c:244: CHECK: Avoid CamelCase: <SCNu64>
> > Nack.  This is userspace only and should be tested as such.
> 
> 
> Thanks for info.
> 
> Yes, warning is correct for kernel space code. Do I understand correctly that
> false positives are ok for user space code in the Linux kernel tree?
> 
> Or is it just because checkpatch.pl has no idea which sources are for user
> space?

Hello Petr.

I suppose another check could be added.
There is function 'is_userspace' available.

I don't know if userspace cares at all about camelcase anyway.

  reply	other threads:[~2026-05-11 23:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 12:12 Petr Vorel
2026-05-11 13:37 ` Simon Glass
2026-05-11 20:55   ` Petr Vorel
2026-05-11 18:54 ` Joe Perches
2026-05-11 21:57   ` Petr Vorel
2026-05-11 23:18     ` Joe Perches [this message]
2026-05-12 18:20       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9e8a6e829c6b7ecba0cc60cacb2c3943e0daf6b.camel@perches.com \
    --to=joe@perches.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=pvorel@suse.cz \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®