From: "J, KEERTHY" <j-keerthy@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>, Dhruva Gole <d-gole@ti.com>
Cc: Vibhore Vardhan <vibhore@ti.com>,
Tony Lindgren <tony@atomide.com>, Vignesh <vigneshr@ti.com>,
Bartosz Golaszewski <brgl@bgdev.pl>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Devarsh Thakkar <devarsht@ti.com>
Subject: Re: [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable bit in save_context
Date: Thu, 30 Mar 2023 08:34:19 +0530 [thread overview]
Message-ID: <48d7ba60-aa7b-8d93-fcf0-c7e64908e9f5@ti.com> (raw)
In-Reply-To: <CACRpkdY_rhe69Y4AbEp8iws1fpL0bUkP5iBMN68EB+wxhFyHTw@mail.gmail.com>
On 3/28/2023 6:59 PM, Linus Walleij wrote:
> On Thu, Mar 23, 2023 at 1:29 PM Dhruva Gole <d-gole@ti.com> wrote:
>
>> The interrupt enable bits might be set if we want to use the GPIO as
>> wakeup source. Clearing this will mean disabling of interrupts in the GPIO
>> banks that we may want to wakeup from.
>> Thus remove the line that was clearing this bit from the driver's save
>> context function.
>>
>> Fixes: 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM")
>> Cc: Devarsh Thakkar <devarsht@ti.com>
>> Signed-off-by: Dhruva Gole <d-gole@ti.com>
>
> Looks like the right solution to me.
> I'm a bit surprised given how long we have had this driver.
> I suppose people have used out-of-tree patches for suspend/resume. :(
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Keerthy <j-keerthy@ti.com>
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2023-03-30 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:29 Dhruva Gole
2023-03-23 12:29 ` [RFC PATCH 2/2] gpio: davinci: Add irq chip flag to skip set wake Dhruva Gole
2023-03-28 13:29 ` Linus Walleij
2023-03-28 13:29 ` [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable bit in save_context Linus Walleij
2023-03-30 3:04 ` J, KEERTHY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48d7ba60-aa7b-8d93-fcf0-c7e64908e9f5@ti.com \
--to=j-keerthy@ti.com \
--cc=brgl@bgdev.pl \
--cc=d-gole@ti.com \
--cc=devarsht@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®