From: Umang Chheda <umang.chheda@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Ruidong Tian <tianruidond@linux.alibaba.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
catalin.marinas@arm.com, will@kernel.org, lpieralisi@kernel.org,
rafael@kernel.org, mark.rutland@arm.com,
Sudeep Holla <sudeep.holla@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/8] dt-bindings: arm: ras: Introduce bindings for ARM AEST
Date: Wed, 20 May 2026 23:43:20 +0530 [thread overview]
Message-ID: <48e298d0-f4cb-4afb-8ba1-a6b39f3285cb@oss.qualcomm.com> (raw)
In-Reply-To: <20260513175823.GA1471517-robh@kernel.org>
Hello Rob,
Thanks for helping reviewing the code!
On 5/13/2026 11:28 PM, Rob Herring wrote:
> On Tue, May 05, 2026 at 05:53:49PM +0530, Umang Chheda wrote:
>> The Arm Error Source Table (AEST) specification describes how firmware
>> exposes RAS error source topology to the operating system. On ACPI
>> systems this information is provided via the AEST ACPI table.
>>
>> Introduce Device Tree bindings that provide an equivalent description
>> of AEST error sources for DT-based platforms.
>>
>> Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/arm/arm,aest.yaml | 406 +++++++++++++++++++++
>> include/dt-bindings/arm/aest.h | 43 +++
>> 2 files changed, 449 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/arm,aest.yaml b/Documentation/devicetree/bindings/arm/arm,aest.yaml
>> new file mode 100644
>> index 000000000000..7809a0d38270
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/arm,aest.yaml
>> @@ -0,0 +1,406 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/arm,aest.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Arm Error Source Table (AEST)
>> +
>> +maintainers:
>> + - Umang Chheda <umang.chheda@oss.qualcomm.com>
>> +
>> +description:
>> + The Arm Error Source Table (AEST) describes RAS error sources and their
>> + register interfaces. Each error source exposes one or more error records
>> + through either system registers or a memory-mapped register window, and
>> + may signal errors via interrupts. The top-level node acts as a container
>> + for one or more child nodes, each describing a single AEST error source.
>> + Refer to the Arm AEST specification (DEN0085 / DDI 0587B) for details.
>> + Flag bit constants for use in DT source files are defined in
>> + <dt-bindings/arm/aest.h>.
>> +
>> +properties:
>> + compatible:
>> + const: arm,aest
>> +
>> + "#address-cells":
>> + const: 2
>> +
>> + "#size-cells":
>> + const: 2
>> +
>> + ranges: true
>> +
>> +required:
>> + - compatible
>> +
>> +additionalProperties: false
>> +
>> +patternProperties:
>> + "^aest-[a-z0-9-]+(@[0-9a-f]+)?$":
>> + type: object
>> + description:
>> + An AEST error source node describing one error source defined by
>> + the Arm AEST specification.
>> +
>> + properties:
>> + compatible:
>> + description:
>> + Identifies the type of AEST error source. Each value corresponds to
>> + a distinct error source class defined by the Arm AEST specification.
>> + arm,aest-proxy represents a proxy error source that forwards errors
>> + from another error source.
>> + enum:
>> + - arm,aest-processor
>> + - arm,aest-memory
>> + - arm,aest-smmu
>> + - arm,aest-gic
>> + - arm,aest-pcie
>> + - arm,aest-vendor
>> + - arm,aest-proxy
>
> This is a fundamental difference how DT and ACPI get structured. ACPI
> defines new table for some feature and puts everything in that table.
> For DT, these all belong in the node for the corresponding h/w. For
> example, if the GIC supports AEST, then that belongs in the GIC node.
Thanks for the feedback. To clarify your suggestion — should the AEST
RAS properties be added directly as properties of the hardware node
(e.g. arm,ras-num-records inside the cpu@0 node itself), or as a child
node under the hardware node (e.g. a ras-error-source {} child under cpu@0)?
>
>> +
>> + reg:
>> + description:
>> + Register ranges for the error source. Absence of reg implies
>> + system-register access (interface type 0). A single range implies
>> + memory-mapped access (interface type 1). Two ranges imply
>> + single-record memory-mapped access (interface type 2).
>> + minItems: 1
>> + maxItems: 4
>> +
>> + reg-names:
>> + description:
>> + Names for the register ranges. The base error-record window is
>> + unnamed (or first entry). Optional named ranges provide access to
>> + the fault-injection, error-group, and interrupt-config register
>> + windows defined by the AEST specification.
>> + minItems: 1
>> + maxItems: 4
>> + items:
>> + enum:
>> + - fault-inject
>> + - err-group
>> + - irq-config
>> +
>> + interrupts:
>> + description: Interrupts associated with the error source.
>> + minItems: 1
>> + maxItems: 2
>> +
>> + interrupt-names:
>> + description: Names of the interrupts associated with the error source.
>> + minItems: 1
>> + maxItems: 2
>> + items:
>> + enum:
>> + - fhi
>> + - eri
>> +
>> + arm,fhi-flags:
>> + description:
>> + Bitmask of flags for the fault-handling interrupt (FHI), as defined
>> + in the AEST node interrupt structure flags field. Constants are
>> + defined in <dt-bindings/arm/aest.h> - AEST_IRQ_MODE_LEVEL (0),
>> + AEST_IRQ_MODE_EDGE (1).
>
> DT already has a way to define interrupt flags. Why invent something
> new?
Ack, this flag is not needed for DT based systems, will remove this.
>
> Rob
Thanks,
Umang
next prev parent reply other threads:[~2026-05-20 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 12:23 [PATCH 0/8] ras: aest: extend AEST support to Device Tree frontend Umang Chheda
2026-05-05 12:23 ` [PATCH 1/8] ras: aest: Fix shared processor node handling and error log messages Umang Chheda
2026-05-05 12:23 ` [PATCH 2/8] ras: aest: Fix CE/UE error counts not incrementing in debugfs Umang Chheda
2026-05-05 12:23 ` [PATCH 3/8] ras: aest: Skip unimplemented records " Umang Chheda
2026-05-05 12:23 ` [PATCH 4/8] ras: aest: Add panic_on_ue module parameter Umang Chheda
2026-05-06 8:06 ` Ruidong Tian
2026-05-12 6:51 ` Umang Chheda
2026-05-05 12:23 ` [PATCH 5/8] dt-bindings: arm: ras: Introduce bindings for ARM AEST Umang Chheda
2026-05-13 17:58 ` Rob Herring
2026-05-20 18:13 ` Umang Chheda [this message]
2026-06-03 10:27 ` Umang Chheda
2026-05-05 12:23 ` [PATCH 6/8] ras: aest: Add DT frontend for ARM AEST RAS error sources Umang Chheda
2026-05-05 12:23 ` [PATCH 7/8] arm64: dts: qcom: lemans: add AEST error nodes Umang Chheda
2026-05-05 12:23 ` [PATCH 8/8] arm64: dts: qcom: monaco: " Umang Chheda
2026-05-12 11:28 ` Konrad Dybcio
2026-05-20 5:04 ` Umang Chheda
2026-05-06 8:10 ` [PATCH 0/8] ras: aest: extend AEST support to Device Tree frontend Ruidong Tian
2026-05-12 6:45 ` Umang Chheda
2026-05-20 5:54 ` Ruidong Tian
2026-06-02 7:29 ` Ruidong Tian
2026-06-08 9:45 ` Umang Chheda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e298d0-f4cb-4afb-8ba1-a6b39f3285cb@oss.qualcomm.com \
--to=umang.chheda@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@kernel.org \
--cc=tianruidond@linux.alibaba.com \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®