mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Tomasz Nowicki <tnowicki@caviumnetworks.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	<linux-acpi@vger.kernel.org>
Cc: <mark.rutland@arm.com>, <Jonathan.Zhang@cavium.com>,
	<Jayachandran.Nair@cavium.com>, <lorenzo.pieralisi@arm.com>,
	<austinwc@codeaurora.org>, <linux-pm@vger.kernel.org>,
	<jhugo@codeaurora.org>, <gregkh@linuxfoundation.org>,
	<sudeep.holla@arm.com>, <rjw@rjwysocki.net>,
	<linux-kernel@vger.kernel.org>, <will.deacon@arm.com>,
	<wangxiongfeng2@huawei.com>, <viresh.kumar@linaro.org>,
	<hanjun.guo@linaro.org>, <catalin.marinas@arm.com>,
	<ahs3@redhat.com>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing
Date: Thu, 19 Oct 2017 11:25:08 +0100	[thread overview]
Message-ID: <49421fa9-c3ac-c81b-ed2d-a113f676edd8@huawei.com> (raw)
In-Reply-To: <2605aa54-95f7-4619-e632-0a95a68e5fb0@caviumnetworks.com>

On 19/10/2017 06:18, Tomasz Nowicki wrote:
>>
>> Summary:
>>
>> I'm not at all happy with this specification's attempt to leave out
>> pieces of information which make parsing things more deterministic. In
>> this case I'm happy to demote the message level, but not remove it
>> entirely but I do think the obvious case you list shouldn't be the
>> default one.
>>
>> Lastly:
>>
>> I'm assuming the final result is that the table is actually being
>> parsed correctly despite the ugly message?
>
> Indeed, the ThunderX2 PPTT table is being parsed so that topology shown
> in lstopo and lscpu is correct.

Hi Tomasz,

Can you share the lscpu output? Does it have cluster info? I did not 
think that lscpu has a concept of clustering.

I would say that the per-cpu cluster index sysfs entry needs be added to 
drivers/base/arch_topology.c (and other appropiate code under 
GENERIC_ARCH_TOPOLOGY) to support this.

Thanks,
John


>
> Thanks,
> Tomasz

  reply	other threads:[~2017-10-19 10:26 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 19:48 [PATCH v3 0/7] Support PPTT for ARM64 Jeremy Linton
2017-10-12 19:48 ` [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing Jeremy Linton
2017-10-13  9:56   ` Julien Thierry
2017-10-13 22:41     ` Jeremy Linton
2017-10-13 14:23   ` tn
2017-10-13 19:58     ` Jeremy Linton
2017-10-16 14:24   ` John Garry
2017-10-17 13:25   ` Tomasz Nowicki
2017-10-17 15:22     ` Jeremy Linton
2017-10-18  1:10       ` Xiongfeng Wang
2017-10-18  5:39       ` Tomasz Nowicki
2017-10-18 10:24         ` Tomasz Nowicki
2017-10-18 17:30           ` Jeremy Linton
2017-10-19  5:18             ` Tomasz Nowicki
2017-10-19 10:25               ` John Garry [this message]
2017-10-27  5:21                 ` Tomasz Nowicki
2017-10-19 14:24               ` Jeremy Linton
2017-10-19 10:22   ` Lorenzo Pieralisi
2017-10-19 15:43     ` Jeremy Linton
2017-10-20 10:15       ` Lorenzo Pieralisi
2017-10-20 19:53   ` Christ, Austin
2017-10-23 21:14     ` Jeremy Linton
2017-10-12 19:48 ` [PATCH v3 2/7] ACPI: Enable PPTT support on ARM64 Jeremy Linton
2017-10-13  9:53   ` Hanjun Guo
2017-10-13 17:51     ` Jeremy Linton
2017-10-18 16:47   ` Lorenzo Pieralisi
2017-10-18 17:38     ` Jeremy Linton
2017-10-19  9:12       ` Lorenzo Pieralisi
2017-10-12 19:48 ` [PATCH v3 3/7] drivers: base: cacheinfo: arm64: Add support for ACPI based firmware tables Jeremy Linton
2017-10-19 15:20   ` Lorenzo Pieralisi
2017-10-19 15:52     ` Jeremy Linton
2017-10-12 19:48 ` [PATCH v3 4/7] Topology: Add cluster on die macros and arm64 decoding Jeremy Linton
2017-10-12 19:48 ` [PATCH v3 5/7] arm64: Fixup users of topology_physical_package_id Jeremy Linton
2017-10-12 19:48 ` [PATCH v3 6/7] arm64: topology: Enable ACPI/PPTT based CPU topology Jeremy Linton
2017-10-19 15:56   ` Lorenzo Pieralisi
2017-10-19 16:13     ` Jeremy Linton
2017-10-20  9:14       ` Lorenzo Pieralisi
2017-10-20 16:14         ` Jeremy Linton
2017-10-20 16:42           ` Sudeep Holla
2017-10-20 19:55           ` Jeffrey Hugo
2017-10-23 21:26             ` Jeremy Linton
2017-10-19 16:54     ` Jeremy Linton
2017-10-20  9:22       ` Lorenzo Pieralisi
2017-11-01 20:29         ` Al Stone
2017-11-02 10:48           ` Lorenzo Pieralisi
2017-10-12 19:48 ` [PATCH v3 7/7] ACPI: Add PPTT to injectable table list Jeremy Linton
2017-10-13 11:08 ` [PATCH v3 0/7] Support PPTT for ARM64 John Garry
2017-10-13 19:34   ` Jeremy Linton
2017-10-31 12:46 ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49421fa9-c3ac-c81b-ed2d-a113f676edd8@huawei.com \
    --to=john.garry@huawei.com \
    --cc=Jayachandran.Nair@cavium.com \
    --cc=Jonathan.Zhang@cavium.com \
    --cc=ahs3@redhat.com \
    --cc=austinwc@codeaurora.org \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanjun.guo@linaro.org \
    --cc=jeremy.linton@arm.com \
    --cc=jhugo@codeaurora.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=tnowicki@caviumnetworks.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wangxiongfeng2@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®