Re: mmotm 2008-12-15-16-45 uploaded (build errors)

Re: mmotm 2008-12-15-16-45 uploaded (build errors)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2008-12-15-16-45 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc8:


Summary of build errors:

i386
=====
build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
build-r7178.out:make[2]: *** [mm/vmscan.o] Error 1
build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'
build-r7178.out:make[3]: *** [fs/fuse/file.o] Error 1
7188	same
7190	same
7195	same

build-r7179.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'
build-r7179.out:make[3]: *** [fs/fuse/file.o] Error 1
7180	same

build-r7181.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/reiser4/plugin/file/file_conversion.c:689: error: implicit declaration of function '__grab_cache_page'
build-r7181.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1


x86_64
=====
build-r7182.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
build-r7182.out:make[2]: *** [mm/vmscan.o] Error 1
build-r7182.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'
build-r7182.out:make[3]: *** [fs/fuse/file.o] Error 1
7185	same
7189	same
7191	same

build-r7183.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
build-r7183.out:make[2]: *** [mm/vmscan.o] Error 1
build-r7183.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/reiser4/plugin/file/fi le_conversion.c:689: error: implicit declaration of function '__grab_cache_page'
build-r7183.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1

build-r7184.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
build-r7184.out:make[3]: *** [fs/ubifs/file.o] Error 1


~Randy
(need .config files?)

Re: mmotm 2008-12-15-16-45 uploaded (build errors)

[Li Zefan]

CC: Nick Piggin <nickpiggin@yahoo.com.au>

Randy Dunlap wrote:
> akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2008-12-15-16-45 has been uploaded to
>>
>>    http://userweb.kernel.org/~akpm/mmotm/
>>
>> It contains the following patches against 2.6.28-rc8:
> 
> 
> Summary of build errors:
> 
> i386
> =====
> build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
> build-r7178.out:make[2]: *** [mm/vmscan.o] Error 1

> build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'

I got this compile error too:

This patch removed __grab_cache_page():
	fs-symlink-write_begin-allocation-context-fix.patch

But mainline has 2 __grab_cache_page() in fuse.c, and the above patch seems just remove 1 of them.

And this patch adds another use of __grab_cache_page():
	reiser4-adjust-to-the-new-aops.patch()


> build-r7178.out:make[3]: *** [fs/fuse/file.o] Error 1
> 7188	same
> 7190	same
> 7195	same
> 
> build-r7179.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'
> build-r7179.out:make[3]: *** [fs/fuse/file.o] Error 1
> 7180	same
> 
> build-r7181.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/reiser4/plugin/file/file_conversion.c:689: error: implicit declaration of function '__grab_cache_page'
> build-r7181.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> 
> 
> x86_64
> =====
> build-r7182.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
> build-r7182.out:make[2]: *** [mm/vmscan.o] Error 1
> build-r7182.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/fuse/file.c:792: error : implicit declaration of function '__grab_cache_page'
> build-r7182.out:make[3]: *** [fs/fuse/file.o] Error 1
> 7185	same
> 7189	same
> 7191	same
> 
> build-r7183.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
> build-r7183.out:make[2]: *** [mm/vmscan.o] Error 1
> build-r7183.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/reiser4/plugin/file/fi le_conversion.c:689: error: implicit declaration of function '__grab_cache_page'
> build-r7183.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> 
> build-r7184.out:/local/linsrc/tmp/mmotm-2008-1215-1645/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
> build-r7184.out:make[3]: *** [fs/ubifs/file.o] Error 1
> 
> 
> ~Randy
> (need .config files?)

Re: mmotm 2008-12-15-16-45 uploaded (build errors)

[KOSAKI Motohiro]

> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2008-12-15-16-45 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > It contains the following patches against 2.6.28-rc8:
> 
> 
> Summary of build errors:
> 
> i386
> =====
> build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
> build-r7178.out:make[2]: *** [mm/vmscan.o] Error 1

I think my fault.
I'll investigate soon.

Re: mmotm 2008-12-15-16-45 uploaded (build errors)

[KOSAKI Motohiro]

> > akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2008-12-15-16-45 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > It contains the following patches against 2.6.28-rc8:
> > 
> > 
> > Summary of build errors:
> > 
> > i386
> > =====
> > build-r7178.out:/local/linsrc/tmp/mmotm-2008-1215-1645/mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'
> > build-r7178.out:make[2]: *** [mm/vmscan.o] Error 1
> 
> I think my fault.
> I'll investigate soon.

fixing is here.


==========================================================
Applied after: memcg-fix-calclation-of-active_ratio.patch

==
Subject: [mmotm][PATCH] memcg: fix calclation of active_ratio build error fix

fix following build error

	  CC      mm/vmscan.o
	mm/vmscan.c: In function 'inactive_anon_is_low':
	mm/vmscan.c:1397: error: too few arguments to function 'mem_cgroup_inactive_anon_is_low'


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 include/linux/memcontrol.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/include/linux/memcontrol.h
===================================================================
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -243,7 +243,7 @@ static inline bool mem_cgroup_oom_called
 }
 
 static inline int
-mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg, struct zone *zone)
+mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg)
 {
 	return 1;
 }

[mmotm][PATCH] Add #include <linux/irqflags.h> to acpi/processor_idle.c

[KOSAKI Motohiro]

Applied after: remove-linux-hardirqh-from-asm-generic-localh.patch

=
Subject: [mmotm][PATCH] Add #include <linux/irqflags.h> to acpi/processor_idle.c

In past, processor_idle.c include irqflags.h indirectly via local.h.
But now, its inclusion was removed.

Then following build error happend.

	  CC [M]  drivers/acpi/processor_idle.o
	drivers/acpi/processor_idle.c: In function 'acpi_cstate_enter':
	drivers/acpi/processor_idle.c:275: error: implicit declaration of function 'stop_critical_timings'
	drivers/acpi/processor_idle.c:288: error: implicit declaration of function 'start_critical_timings'
	make[1]: *** [drivers/acpi/processor_idle.o] Error 1
	make: *** [drivers/acpi/processor_idle.o] Error 2


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Russell King <rmk+kernel@arm.linux.org.uk>
CC: Steven Rostedt <rostedt@goodmis.org>
---
 drivers/acpi/processor_idle.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/acpi/processor_idle.c
===================================================================
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -41,6 +41,7 @@
 #include <linux/pm_qos_params.h>
 #include <linux/clockchips.h>
 #include <linux/cpuidle.h>
+#include <linux/irqflags.h>
 
 /*
  * Include the apic definitions for x86 to have the APIC timer related defines

Re: mmotm 2008-12-15-16-45 uploaded

[KAMEZAWA Hiroyuki]

On Mon, 15 Dec 2008 16:45:59 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-12-15-16-45 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc8:
> 
This patch was necessary...maybe fixed by linux-next.

==
Don't call __cfq_exit_single_io_context() twice.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
Index: mmotm-2.6.28-Dec15/block/cfq-iosched.c
===================================================================
--- mmotm-2.6.28-Dec15.orig/block/cfq-iosched.c
+++ mmotm-2.6.28-Dec15/block/cfq-iosched.c
@@ -1322,7 +1322,6 @@ static void cfq_exit_single_io_context(s
 		smp_read_barrier_depends();
 		if (cic->key)
 			__cfq_exit_single_io_context(cfqd, cic);
-		__cfq_exit_single_io_context(cfqd, cic);
 
 		spin_unlock_irqrestore(q->queue_lock, flags);
 	}