* Re: linux-next: Tree for December 18 (slow-work)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
@ 2008-12-18 17:21 ` Randy Dunlap
2008-12-18 17:25 ` linux-next: Tree for December 18 (fscache) Randy Dunlap
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2008-12-18 17:21 UTC (permalink / raw)
To: Stephen Rothwell, dhowells; +Cc: linux-next, LKML
when CONFIG_SYSCTL=n:
build-r7380.out:/local/linsrc/linux-next-20081218/kernel/slow-work.c:612: error: 'slow_work_max_max_threads' undeclared (first use in this function)
build-r7380.out:make[2]: *** [kernel/slow-work.o] Error 1
---
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (fscache)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
2008-12-18 17:21 ` linux-next: Tree for December 18 (slow-work) Randy Dunlap
@ 2008-12-18 17:25 ` Randy Dunlap
2008-12-18 17:45 ` linux-next: Tree for December 18 (slow-work) David Howells
` (3 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2008-12-18 17:25 UTC (permalink / raw)
To: Stephen Rothwell, dhowells; +Cc: linux-next, LKML
On Thu, 18 Dec 2008 23:06:37 +1100 Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20081217:
>
> New tree:
> fscache
When CONFIG_BLOCK=n:
build-r7417.out:/local/linsrc/linux-next-20081218/fs/cachefiles/cf-interface.c:357: error: implicit declaration of function 'fsync_super'
build-r7417.out:make[3]: *** [fs/cachefiles/cf-interface.o] Error 1
Should include/linux/buffer_head.h have an empty stub for fsync_super()
or does fscache even make sense when CONFIG_BLOCK=n?
---
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (slow-work)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
2008-12-18 17:21 ` linux-next: Tree for December 18 (slow-work) Randy Dunlap
2008-12-18 17:25 ` linux-next: Tree for December 18 (fscache) Randy Dunlap
@ 2008-12-18 17:45 ` David Howells
2008-12-18 17:47 ` linux-next: Tree for December 18 (fscache) David Howells
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: David Howells @ 2008-12-18 17:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: dhowells, Stephen Rothwell, linux-next, LKML
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> when CONFIG_SYSCTL=n:
>
> build-r7380.out:/local/linsrc/linux-next-20081218/kernel/slow-work.c:612: error: 'slow_work_max_max_threads' undeclared (first use in this function)
> build-r7380.out:make[2]: *** [kernel/slow-work.o] Error 1
Bah.
David
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (fscache)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
` (2 preceding siblings ...)
2008-12-18 17:45 ` linux-next: Tree for December 18 (slow-work) David Howells
@ 2008-12-18 17:47 ` David Howells
2008-12-18 23:57 ` linux-next: Tree for December 18 (irq.h documentation) Randy Dunlap
2008-12-19 0:14 ` linux-next: Tree for December 18 (patch: kernel-doc notation) Randy Dunlap
5 siblings, 0 replies; 13+ messages in thread
From: David Howells @ 2008-12-18 17:47 UTC (permalink / raw)
To: Randy Dunlap; +Cc: dhowells, Stephen Rothwell, linux-next, LKML
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Should include/linux/buffer_head.h have an empty stub for fsync_super()
> or does fscache even make sense when CONFIG_BLOCK=n?
FS-Cache might. CacheFiles probably doesn't.
There've been discussions about a separate caching backend to deal with
non-rotating media such as large chunks of battery-backed RAM or flash.
FS-Cache might make sense in such a situation as these could be accessed in
other ways (such as through MTD or even directly).
I'll make CONFIG_CACHEFILES dependent on CONFIG_BLOCK.
David
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (irq.h documentation)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
` (3 preceding siblings ...)
2008-12-18 17:47 ` linux-next: Tree for December 18 (fscache) David Howells
@ 2008-12-18 23:57 ` Randy Dunlap
2008-12-19 0:33 ` Yinghai Lu
2008-12-19 0:14 ` linux-next: Tree for December 18 (patch: kernel-doc notation) Randy Dunlap
5 siblings, 1 reply; 13+ messages in thread
From: Randy Dunlap @ 2008-12-18 23:57 UTC (permalink / raw)
To: Stephen Rothwell, Yinghai Lu; +Cc: linux-next, LKML, Ingo Molnar
Hi YH,
Whenever you update a struct in a header file that uses kernel-doc,
like struct irq_desc in include/linux/irq.h, please also update the
corresponding kernel-doc notation for the new struct members, so
that kernel-doc warnings are not caused:
from linux-next-20081218:
Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'timer_rand_state'
Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'kstat_irqs'
Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'irq_2_iommu'
Please add kernel-doc notation for those missing struct members.
Thanks,
---
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (irq.h documentation)
2008-12-18 23:57 ` linux-next: Tree for December 18 (irq.h documentation) Randy Dunlap
@ 2008-12-19 0:33 ` Yinghai Lu
2008-12-19 0:45 ` Randy Dunlap
2008-12-19 0:57 ` Yinghai Lu
0 siblings, 2 replies; 13+ messages in thread
From: Yinghai Lu @ 2008-12-19 0:33 UTC (permalink / raw)
To: Randy Dunlap, Ingo Molnar; +Cc: Stephen Rothwell, linux-next, LKML
Randy Dunlap wrote:
> Hi YH,
>
> Whenever you update a struct in a header file that uses kernel-doc,
> like struct irq_desc in include/linux/irq.h, please also update the
> corresponding kernel-doc notation for the new struct members, so
> that kernel-doc warnings are not caused:
>
> from linux-next-20081218:
>
> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'timer_rand_state'
> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'kstat_irqs'
> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'irq_2_iommu'
>
>
please check
[PATCH] sparseirq: add kernel-doc notation for new member in irq_desc
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1beb63a..4675682 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -135,6 +135,9 @@ struct irq_2_iommu;
/**
* struct irq_desc - interrupt descriptor
* @irq: interrupt number for this descriptor
+ * @timer_rand_state pointer to timer rand state struct
+ * @kstat_irqs irq stats per cpu
+ * @irq_2_iommu iommu with this irq
* @handle_irq: highlevel irq-events handler [if NULL, __do_IRQ()]
* @chip: low level interrupt hardware access
* @msi_desc: MSI descriptor
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next: Tree for December 18 (irq.h documentation)
2008-12-19 0:33 ` Yinghai Lu
@ 2008-12-19 0:45 ` Randy Dunlap
2008-12-19 0:57 ` Yinghai Lu
1 sibling, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2008-12-19 0:45 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Ingo Molnar, Stephen Rothwell, linux-next, LKML
Yinghai Lu wrote:
> Randy Dunlap wrote:
>> Hi YH,
>>
>> Whenever you update a struct in a header file that uses kernel-doc,
>> like struct irq_desc in include/linux/irq.h, please also update the
>> corresponding kernel-doc notation for the new struct members, so
>> that kernel-doc warnings are not caused:
>>
>> from linux-next-20081218:
>>
>> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'timer_rand_state'
>> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'kstat_irqs'
>> Warning(linux-next-20081218//include/linux/irq.h:192): No description found for parameter 'irq_2_iommu'
>>
>>
> please check
Thanks. Please see below.
> [PATCH] sparseirq: add kernel-doc notation for new member in irq_desc
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 1beb63a..4675682 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -135,6 +135,9 @@ struct irq_2_iommu;
> /**
> * struct irq_desc - interrupt descriptor
> * @irq: interrupt number for this descriptor
> + * @timer_rand_state pointer to timer rand state struct
> + * @kstat_irqs irq stats per cpu
> + * @irq_2_iommu iommu with this irq
Format is:
* @member: description
I.e., please add a ':' after each member name.
> * @handle_irq: highlevel irq-events handler [if NULL, __do_IRQ()]
> * @chip: low level interrupt hardware access
> * @msi_desc: MSI descriptor
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next: Tree for December 18 (irq.h documentation)
2008-12-19 0:33 ` Yinghai Lu
2008-12-19 0:45 ` Randy Dunlap
@ 2008-12-19 0:57 ` Yinghai Lu
2008-12-19 1:00 ` Randy Dunlap
1 sibling, 1 reply; 13+ messages in thread
From: Yinghai Lu @ 2008-12-19 0:57 UTC (permalink / raw)
To: Randy Dunlap, Ingo Molnar; +Cc: Stephen Rothwell, linux-next, LKML
please check
[PATCH] sparseirq: add kernel-doc notation for new member in irq_desc -v2
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1beb63a..5845bdc 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -135,6 +135,9 @@ struct irq_2_iommu;
/**
* struct irq_desc - interrupt descriptor
* @irq: interrupt number for this descriptor
+ * @timer_rand_state: pointer to timer rand state struct
+ * @kstat_irqs: irq stats per cpu
+ * @irq_2_iommu: iommu with this irq
* @handle_irq: highlevel irq-events handler [if NULL, __do_IRQ()]
* @chip: low level interrupt hardware access
* @msi_desc: MSI descriptor
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next: Tree for December 18 (irq.h documentation)
2008-12-19 0:57 ` Yinghai Lu
@ 2008-12-19 1:00 ` Randy Dunlap
0 siblings, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2008-12-19 1:00 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Ingo Molnar, Stephen Rothwell, linux-next, LKML
Yinghai Lu wrote:
> please check
>
> [PATCH] sparseirq: add kernel-doc notation for new member in irq_desc -v2
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 1beb63a..5845bdc 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -135,6 +135,9 @@ struct irq_2_iommu;
> /**
> * struct irq_desc - interrupt descriptor
> * @irq: interrupt number for this descriptor
> + * @timer_rand_state: pointer to timer rand state struct
> + * @kstat_irqs: irq stats per cpu
> + * @irq_2_iommu: iommu with this irq
> * @handle_irq: highlevel irq-events handler [if NULL, __do_IRQ()]
> * @chip: low level interrupt hardware access
> * @msi_desc: MSI descriptor
>
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next: Tree for December 18 (patch: kernel-doc notation)
2008-12-18 12:06 linux-next: Tree for December 18 Stephen Rothwell
` (4 preceding siblings ...)
2008-12-18 23:57 ` linux-next: Tree for December 18 (irq.h documentation) Randy Dunlap
@ 2008-12-19 0:14 ` Randy Dunlap
2008-12-19 10:39 ` Dave Chinner
2008-12-22 22:49 ` Andrew Morton
5 siblings, 2 replies; 13+ messages in thread
From: Randy Dunlap @ 2008-12-19 0:14 UTC (permalink / raw)
To: Stephen Rothwell, Dave Chinner; +Cc: linux-next, LKML, akpm
fs/inode.c and mm/filemap.c need kernel-doc fixes.
What tree were these merged into for linux-next?
How do I get these doc fixes merged? (2 patches below)
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix fs/inode.c kernel-doc function parameters:
Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'sb'
Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'inode'
Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'sb'
Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'inode'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Dave Chinner <david@fromorbit.com>
---
fs/inode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-next-20081218.orig/fs/inode.c
+++ linux-next-20081218/fs/inode.c
@@ -110,8 +110,8 @@ static void wake_up_inode(struct inode *
/**
* inode_init_always - perform inode structure intialisation
- * @sb - superblock inode belongs to.
- * @inode - inode to initialise
+ * @sb: superblock inode belongs to
+ * @inode: inode to initialise
*
* These are initializations that need to be done on every inode
* allocation as the fields are not initialised by slab allocation.
@@ -574,8 +574,8 @@ __inode_add_to_lists(struct super_block
/**
* inode_add_to_lists - add a new inode to relevant lists
- * @sb - superblock inode belongs to.
- * @inode - inode to mark in use
+ * @sb: superblock inode belongs to
+ * @inode: inode to mark in use
*
* When an inode is allocated it needs to be accounted for, added to the in use
* list, the owning superblock and the inode hash. This needs to be done under
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix mm/filemap.c functions' kernel-doc:
Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:575): No description found for parameter 'page'
Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:575): No description found for parameter 'waiter'
Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'mapping'
Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'index'
Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'source'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Dave Chinner <david@fromorbit.com>
---
mm/filemap.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
--- linux-next-20081218.orig/mm/filemap.c
+++ linux-next-20081218/mm/filemap.c
@@ -566,8 +566,8 @@ EXPORT_SYMBOL(wait_on_page_bit);
/**
* add_page_wait_queue - Add an arbitrary waiter to a page's wait queue
- * @page - Page defining the wait queue of interest
- * @waiter - Waiter to add to the queue
+ * @page: Page defining the wait queue of interest
+ * @waiter: Waiter to add to the queue
*
* Add an arbitrary @waiter to the wait queue for the nominated @page.
*/
@@ -2328,11 +2328,10 @@ generic_file_buffered_write(struct kiocb
EXPORT_SYMBOL(generic_file_buffered_write);
/**
- * generic_file_buffered_write_one_page - Write a single page of data to an
- * inode
- * @mapping - The address space of the target inode
- * @index - The target page in the target inode to fill
- * @source - The data to write into the target page
+ * generic_file_buffered_write_one_page - Write a single page of data to an inode
+ * @mapping: The address space of the target inode
+ * @index: The target page in the target inode to fill
+ * @source: The data to write into the target page
*
* Write the data from the source page to the page in the nominated address
* space at the @index specified. Note that the file will not be extended if
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next: Tree for December 18 (patch: kernel-doc notation)
2008-12-19 0:14 ` linux-next: Tree for December 18 (patch: kernel-doc notation) Randy Dunlap
@ 2008-12-19 10:39 ` Dave Chinner
2008-12-22 22:49 ` Andrew Morton
1 sibling, 0 replies; 13+ messages in thread
From: Dave Chinner @ 2008-12-19 10:39 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, akpm
On Thu, Dec 18, 2008 at 04:14:37PM -0800, Randy Dunlap wrote:
> fs/inode.c and mm/filemap.c need kernel-doc fixes.
>
> What tree were these merged into for linux-next?
The fs/inode.c one ended up going through the XFS tree because
of the XFs code dependent on it....
> How do I get these doc fixes merged? (2 patches below)
Perhaps best to go through the VFS tree for fs/inode.c changes.
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix fs/inode.c kernel-doc function parameters:
>
> Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'sb'
> Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'inode'
> Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'sb'
> Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'inode'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Dave Chinner <david@fromorbit.com>
Looks fine to me.
Reviewed-by: Dave Chinner <david@fromorbit.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next: Tree for December 18 (patch: kernel-doc notation)
2008-12-19 0:14 ` linux-next: Tree for December 18 (patch: kernel-doc notation) Randy Dunlap
2008-12-19 10:39 ` Dave Chinner
@ 2008-12-22 22:49 ` Andrew Morton
1 sibling, 0 replies; 13+ messages in thread
From: Andrew Morton @ 2008-12-22 22:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: sfr, david, linux-next, linux-kernel
On Thu, 18 Dec 2008 16:14:37 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> fs/inode.c and mm/filemap.c need kernel-doc fixes.
>
> What tree were these merged into for linux-next?
I use git-blame.
> How do I get these doc fixes merged? (2 patches below)
>
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix fs/inode.c kernel-doc function parameters:
>
> Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'sb'
> Warning(linux-next-20081218//fs/inode.c:120): No description found for parameter 'inode'
> Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'sb'
> Warning(linux-next-20081218//fs/inode.c:588): No description found for parameter 'inode'
>
>From the XFS tree:
commit 2cb1599f9b2ecdd7a9e59feeee647eb258966839
Author: David Chinner <david@fromorbit.com>
AuthorDate: Thu Oct 30 17:32:23 2008 +1100
Commit: Lachlan McIlroy <lachlan@redback.melbourne.sgi.com>
CommitDate: Thu Oct 30 17:32:23 2008 +1100
Inode: Allow external initialisers
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix mm/filemap.c functions' kernel-doc:
>
> Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:575): No description found for parameter 'page'
> Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:575): No description found for parameter 'waiter'
> Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'mapping'
> Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'index'
> Warning(/local/linsrc/linux-next-20081218//mm/filemap.c:2348): No description found for parameter 'source'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Dave Chinner <david@fromorbit.com>
That's no longer in linux-next. I'd guess it was from the fs-cache
patches.
^ permalink raw reply [flat|nested] 13+ messages in thread