From: Paolo Abeni <pabeni@redhat.com>
To: David Yang <mmyangfl@gmail.com>, netdev@vger.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: dsa: eliminate local type for tc policers
Date: Thu, 5 Feb 2026 15:44:19 +0100 [thread overview]
Message-ID: <49573634-3837-4f35-908a-44ccdadca1f8@redhat.com> (raw)
In-Reply-To: <20260203172207.98533-1-mmyangfl@gmail.com>
On 2/3/26 6:22 PM, David Yang wrote:
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 596ab9791e4d..a2b1b752958a 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -275,7 +275,7 @@ struct flow_action_entry {
> u32 trunc_size;
> bool truncate;
> } sample;
> - struct { /* FLOW_ACTION_POLICE */
> + struct flow_action_police { /* FLOW_ACTION_POLICE */
> u32 burst;
> u64 rate_bytes_ps;
> u64 peakrate_bytes_ps;
I find a bit unusual put the new type definition inside a wider struct.
I think it would be better move the struct flow_action_police standalone.
/P
prev parent reply other threads:[~2026-02-05 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:22 David Yang
2026-02-05 14:44 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49573634-3837-4f35-908a-44ccdadca1f8@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®