From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Crestez Dan Leonard <leonard.crestez@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Linux I2C <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] regmap: Add regmap_pipe_read API
Date: Sun, 19 Jun 2016 20:40:05 +0100 [thread overview]
Message-ID: <495a344d-7d89-bee5-640d-a9ac78a49507@kernel.org> (raw)
In-Reply-To: <5763AF5D.4090309@metafoo.de>
On 17/06/16 09:05, Lars-Peter Clausen wrote:
> On 06/17/2016 09:04 AM, Crestez Dan Leonard wrote:
>> On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote:
>>> Hi Leonard,
>>>
>>> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard
>>> <leonard.crestez@intel.com> wrote:
>>>> The regmap API usually assumes that bulk read operations will read a
>>>> range of registers but some I2C/SPI devices have certain registers for
>>>> which a such a read operation will return data from an internal FIFO
>>>> instead. Add an explicit API to support bulk read with pipe rather than
>>>> range semantics.
>>>
>>> Please settle on either "fifo" or "pipe", instead of mixing both.
>>> Personally, I prefer the former.
>>
>> Well, it doesn't have to be a fifo. The device can return data from some
>> other kind of buffer (maybe a stack). I can adjust the documentation to
>> clarify.
>>
>> I considered naming it something like regmap_multi_read_one_reg or
>> something but regmap_pipe_read sounds reasonable and short.
>
> stream might be another option, but pipe is ok in my opinion.
>
I'm not fussy on naming, but definitely support having the functionality!
Jonathan
next prev parent reply other threads:[~2016-06-19 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 15:24 Crestez Dan Leonard
2016-06-16 15:43 ` Geert Uytterhoeven
2016-06-17 7:04 ` Crestez Dan Leonard
2016-06-17 8:05 ` Lars-Peter Clausen
2016-06-19 19:40 ` Jonathan Cameron [this message]
2016-06-21 18:42 ` Mark Brown
2016-06-22 8:32 ` Crestez Dan Leonard
2016-06-22 10:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495a344d-7d89-bee5-640d-a9ac78a49507@kernel.org \
--to=jic23@kernel.org \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®