From: Doug Ledford <dledford@redhat.com>
To: Steve Wise <swise@opengridcomputing.com>,
"'Baoyou Xie'" <baoyou.xie@linaro.org>,
sean.hefty@intel.com, hal.rosenstock@gmail.com
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@linaro.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
Date: Fri, 2 Sep 2016 13:23:47 -0400 [thread overview]
Message-ID: <496842ea-a04f-431b-5eee-6ef6535375ee@redhat.com> (raw)
In-Reply-To: <004001d20201$448119e0$cd834da0$@opengridcomputing.com>
[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]
On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>
> Ignore my comment on v2...
>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-09-02 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 14:57 Baoyou Xie
2016-08-29 14:26 ` Steve Wise
2016-09-02 17:23 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496842ea-a04f-431b-5eee-6ef6535375ee@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome