mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] gpu: ipu-v3: Convert to platform remove callback returning void
Date: Wed, 10 Apr 2024 10:29:25 +0200	[thread overview]
Message-ID: <4969fb7a602fca2354b8d812a0f48bf495d7941e.camel@pengutronix.de> (raw)
In-Reply-To: <dee3c0e1c8c6bd1027a91c65be55ac1d6ba9e099.1712681770.git.u.kleine-koenig@pengutronix.de>

On Di, 2024-04-09 at 19:02 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert the ipu-v3 platform drivers from always returning zero
> in the remove callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

  reply	other threads:[~2024-04-10  8:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 17:02 [PATCH 0/4] gpu: " Uwe Kleine-König
2024-04-09 17:02 ` [PATCH 1/4] drm/imagination: " Uwe Kleine-König
2024-04-16 19:15   ` Matt Coster
2024-04-23  8:29   ` Matt Coster
2024-04-09 17:02 ` [PATCH 2/4] drm/mediatek: " Uwe Kleine-König
2024-05-16  2:54   ` CK Hu (胡俊光)
2024-05-16 10:12   ` AngeloGioacchino Del Regno
2024-04-09 17:02 ` [PATCH 3/4] gpu: host1x: " Uwe Kleine-König
2024-04-19 11:29   ` Thierry Reding
2024-04-09 17:02 ` [PATCH 4/4] gpu: ipu-v3: " Uwe Kleine-König
2024-04-10  8:29   ` Philipp Zabel [this message]
2024-04-09 17:10 ` [PATCH 0/4] gpu: " Uwe Kleine-König
2024-04-09 18:59 ` Thomas Zimmermann
2024-04-19  7:20 ` Uwe Kleine-König
2024-04-19 11:28   ` Thierry Reding
2024-04-23  8:31   ` Matt Coster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4969fb7a602fca2354b8d812a0f48bf495d7941e.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®