From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Shalin Mehta <shalinmehta85@gmail.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
"<kernel-janitors@lists.osdl.org>"
<kernel-janitors@lists.osdl.org>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
Date: Tue, 16 Feb 2016 02:51:51 +0000 [thread overview]
Message-ID: <497A8642-BC1A-4EF9-92BC-C3FF3C217BA2@intel.com> (raw)
In-Reply-To: <1455507422-13568-1-git-send-email-shalinmehta85@gmail.com>
On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
>
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
>
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
>
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
next prev parent reply other threads:[~2016-02-16 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 3:37 Shalin Mehta
2016-02-16 2:28 ` Greg KH
2016-02-16 2:41 ` Drokin, Oleg
2016-02-16 2:51 ` Drokin, Oleg [this message]
2016-02-17 6:39 ` [lustre-devel] " shalin mehta
2016-02-19 10:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497A8642-BC1A-4EF9-92BC-C3FF3C217BA2@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=shalinmehta85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®