From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Shalin Mehta <shalinmehta85@gmail.com>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
"<kernel-janitors@lists.osdl.org>"
<kernel-janitors@lists.osdl.org>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: Fixed the parenthesis
Date: Tue, 16 Feb 2016 02:41:43 +0000 [thread overview]
Message-ID: <6A47AD82-6A8F-44E1-9CB4-C10CF9F9D72E@intel.com> (raw)
In-Reply-To: <20160216022812.GA25122@kroah.com>
On Feb 15, 2016, at 9:28 PM, Greg KH wrote:
> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>
> "fixed" in what way? Did you test-build this patch? Also, you
> mispelled a word here…
The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.
The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.
Compiles work with or without this fix as the result (I also just checked
just to be sure).
next prev parent reply other threads:[~2016-02-16 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 3:37 Shalin Mehta
2016-02-16 2:28 ` Greg KH
2016-02-16 2:41 ` Drokin, Oleg [this message]
2016-02-16 2:51 ` [lustre-devel] " Drokin, Oleg
2016-02-17 6:39 ` shalin mehta
2016-02-19 10:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A47AD82-6A8F-44E1-9CB4-C10CF9F9D72E@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=shalinmehta85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®