* [PATCH] smackfs load append mode fix - resend unmundged.
@ 2009-01-28 4:06 Casey Schaufler
2009-01-28 4:11 ` James Morris
2009-01-28 4:29 ` James Morris
0 siblings, 2 replies; 3+ messages in thread
From: Casey Schaufler @ 2009-01-28 4:06 UTC (permalink / raw)
To: LKLM, LSM, jmorris; +Cc: Ahmed S. Darwish, akpm, torvalds
From: Casey Schaufler <casey@schaufler-ca.com>
Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---
security/smack/smackfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c
--- linux-2.6/security/smack/smackfs.c 2009-01-09 21:43:42.000000000 -0800
+++ linux-0112/security/smack/smackfs.c 2009-01-19 11:05:09.000000000 -0800
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil
break;
case 'a':
case 'A':
- rule.smk_access |= MAY_READ;
+ rule.smk_access |= MAY_APPEND;
break;
default:
goto out;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] smackfs load append mode fix - resend unmundged.
2009-01-28 4:06 [PATCH] smackfs load append mode fix - resend unmundged Casey Schaufler
@ 2009-01-28 4:11 ` James Morris
2009-01-28 4:29 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2009-01-28 4:11 UTC (permalink / raw)
To: Casey Schaufler; +Cc: LKLM, LSM, Ahmed S. Darwish, akpm, torvalds
On Tue, 27 Jan 2009, Casey Schaufler wrote:
> From: Casey Schaufler <casey@schaufler-ca.com>
>
> Given just how hard it is to find the code that uses MAY_APPEND
> it's probably not a big surprise that this went unnoticed for so
> long. The Smack rules loading code is incorrectly setting the
> MAY_READ bit when MAY_APPEND is requested.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Reviewed-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] smackfs load append mode fix - resend unmundged.
2009-01-28 4:06 [PATCH] smackfs load append mode fix - resend unmundged Casey Schaufler
2009-01-28 4:11 ` James Morris
@ 2009-01-28 4:29 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2009-01-28 4:29 UTC (permalink / raw)
To: Casey Schaufler
Cc: LKLM, LSM, Ahmed S. Darwish, Andrew Morton, Linus Torvalds
On Tue, 27 Jan 2009, Casey Schaufler wrote:
> From: Casey Schaufler <casey@schaufler-ca.com>
>
> Given just how hard it is to find the code that uses MAY_APPEND
> it's probably not a big surprise that this went unnoticed for so
> long. The Smack rules loading code is incorrectly setting the
> MAY_READ bit when MAY_APPEND is requested.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
The patch was still corrupt (and you didn't format the subject line
properly).
A fixed version for Linus may be pulled via:
The following changes since commit e4a7ca29039e615ce13a61b9c6abfb2aa394e9a1:
Linus Torvalds (1):
Merge git://git.kernel.org/.../gregkh/usb-2.6
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6 for-linus
Casey Schaufler (1):
smack: smackfs load append mode fix
security/smack/smackfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-28 4:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-28 4:06 [PATCH] smackfs load append mode fix - resend unmundged Casey Schaufler
2009-01-28 4:11 ` James Morris
2009-01-28 4:29 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®