mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	<bcm-kernel-feedback-list@broadcom.com>
Cc: Tejun Heo <tj@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Srinath Mannam <srinath.mannam@broadcom.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
	<linux-ide@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] phy: brcm-sata: Implement calibrate callback
Date: Wed, 17 Jan 2018 10:49:31 +0530	[thread overview]
Message-ID: <497d4542-75a7-fbe4-4ff2-07fe00380d0c@ti.com> (raw)
In-Reply-To: <1515720668-4860-2-git-send-email-f.fainelli@gmail.com>



On Friday 12 January 2018 07:01 AM, Florian Fainelli wrote:
> Implement the calibration callback to allow turning on the Clock-Data
> Recovery module clamping when necessary, e.g: during failure to identify
> a SATA hard drive from ahci_brcm.c::brcm_ahci_read_id.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/phy/broadcom/phy-brcm-sata.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c
> index 3f953db70288..8000ce312d95 100644
> --- a/drivers/phy/broadcom/phy-brcm-sata.c
> +++ b/drivers/phy/broadcom/phy-brcm-sata.c
> @@ -150,6 +150,9 @@ enum sata_phy_regs {
>  	TXPMD_TX_FREQ_CTRL_CONTROL2_FMIN_MASK	= 0x3ff,
>  	TXPMD_TX_FREQ_CTRL_CONTROL3		= 0x84,
>  	TXPMD_TX_FREQ_CTRL_CONTROL3_FMAX_MASK	= 0x3ff,
> +
> +	RXPMD_REG_BANK				= 0x1c0,
> +	RXPMD_RX_FREQ_MON_CONTROL1		= 0x87,
>  };
>  
>  enum sata_phy_ctrl_regs {
> @@ -505,8 +508,37 @@ static int brcm_sata_phy_init(struct phy *phy)
>  	return rc;
>  }
>  
> +static void brcm_stb_sata_calibrate(struct brcm_sata_port *port)
> +{
> +	void __iomem *base = brcm_sata_pcb_base(port);
> +	struct brcm_sata_phy *priv = port->phy_priv;
> +	u32 tmp = BIT(8);
> +
> +	brcm_sata_phy_wr(base, RXPMD_REG_BANK, RXPMD_RX_FREQ_MON_CONTROL1,
> +			 ~tmp, tmp);
> +}
> +
> +static int brcm_sata_phy_calibrate(struct phy *phy)
> +{
> +	struct brcm_sata_port *port = phy_get_drvdata(phy);
> +	int rc = -EOPNOTSUPP;
> +
> +	switch (port->phy_priv->version) {
> +	case BRCM_SATA_PHY_STB_28NM:
> +	case BRCM_SATA_PHY_STB_40NM:
> +		brcm_stb_sata_calibrate(port);
> +		rc = 0;
> +		break;
> +	default:
> +		break;
> +	};
> +
> +	return rc;
> +}
> +
>  static const struct phy_ops phy_ops = {
>  	.init		= brcm_sata_phy_init,
> +	.calibrate	= brcm_sata_phy_calibrate,
>  	.owner		= THIS_MODULE,
>  };
>  
> 

  reply	other threads:[~2018-01-17  5:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12  1:31 [PATCH v2 0/2] ata: ahci_brcm: Recover from failures to identify devices Florian Fainelli
2018-01-12  1:31 ` [PATCH v2 1/2] phy: brcm-sata: Implement calibrate callback Florian Fainelli
2018-01-17  5:19   ` Kishon Vijay Abraham I [this message]
2018-01-12  1:31 ` [PATCH v2 2/2] ata: ahci_brcm: Recover from failures to identify devices Florian Fainelli
2018-01-16 16:09 ` [PATCH v2 0/2] " Tejun Heo
2018-01-17 15:53 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497d4542-75a7-fbe4-4ff2-07fe00380d0c@ti.com \
    --to=kishon@ti.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dan.carpenter@oracle.com \
    --cc=f.fainelli@gmail.com \
    --cc=heiko@sntech.de \
    --cc=krzk@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinath.mannam@broadcom.com \
    --cc=tj@kernel.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®