* [PATCH 1/1] Add devices to spidev device tree compatibility list
@ 2016-09-30 10:15 Fabien Lahoudere
2016-09-30 16:08 ` Mark Brown
2016-09-30 17:35 ` [PATCH 1/1] Add devices " Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Fabien Lahoudere @ 2016-09-30 10:15 UTC (permalink / raw)
To: broonie; +Cc: linux-spi, linux-kernel, Fabien Lahoudere
Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:
- "fsl,mk20fn1m0vmd12" : a cortex m4 based chip
- "exar,xra1403" : a GPIO expander
Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
drivers/spi/spidev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e05046..821937a 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -696,6 +696,8 @@ static struct class *spidev_class;
static const struct of_device_id spidev_dt_ids[] = {
{ .compatible = "rohm,dh2228fv" },
{ .compatible = "lineartechnology,ltc2488" },
+ { .compatible = "fsl,MK20FN1M0VMD12" },
+ { .compatible = "exar,xra1403" },
{},
};
MODULE_DEVICE_TABLE(of, spidev_dt_ids);
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] Add devices to spidev device tree compatibility list
2016-09-30 10:15 [PATCH 1/1] Add devices to spidev device tree compatibility list Fabien Lahoudere
@ 2016-09-30 16:08 ` Mark Brown
2016-10-06 14:44 ` [PATCH v2 1/1] Add device " Fabien Lahoudere
2016-09-30 17:35 ` [PATCH 1/1] Add devices " Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2016-09-30 16:08 UTC (permalink / raw)
To: Fabien Lahoudere; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:
> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip
> + { .compatible = "fsl,MK20FN1M0VMD12" },
This compatible is in uppercase which is not the normal style for DT
bindings at all. I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2 1/1] Add device to spidev device tree compatibility list
2016-09-30 16:08 ` Mark Brown
@ 2016-10-06 14:44 ` Fabien Lahoudere
2016-10-06 14:49 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Fabien Lahoudere @ 2016-10-06 14:44 UTC (permalink / raw)
To: broonie; +Cc: linux-spi, linux-kernel, Fabien Lahoudere
Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entry for the following device:
- "ge,achc" : GE Healthcare USB Management Controller
The USB Management Controller does not expose USB to the host, but acts as
an offload engine, communicating with specific USB based data acquisition
devices which are connected to it, extracting the required data and
providing it to the host via other methods. SPI is used as an out-of-band
configuration channel.
Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
drivers/spi/spidev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e05046..9e2e099 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -696,6 +696,7 @@ static struct class *spidev_class;
static const struct of_device_id spidev_dt_ids[] = {
{ .compatible = "rohm,dh2228fv" },
{ .compatible = "lineartechnology,ltc2488" },
+ { .compatible = "ge,achc" },
{},
};
MODULE_DEVICE_TABLE(of, spidev_dt_ids);
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Add devices to spidev device tree compatibility list
2016-09-30 10:15 [PATCH 1/1] Add devices to spidev device tree compatibility list Fabien Lahoudere
2016-09-30 16:08 ` Mark Brown
@ 2016-09-30 17:35 ` Geert Uytterhoeven
2016-10-06 8:01 ` Fabien Lahoudere
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-09-30 17:35 UTC (permalink / raw)
To: Fabien Lahoudere; +Cc: Mark Brown, linux-spi, linux-kernel
On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
<fabien.lahoudere@collabora.co.uk> wrote:
> Entries are needed in the spidev ID list to configure configure it from a
> device tree. Add entries for the following devices:
> - "exar,xra1403" : a GPIO expander
Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] Add devices to spidev device tree compatibility list
2016-09-30 17:35 ` [PATCH 1/1] Add devices " Geert Uytterhoeven
@ 2016-10-06 8:01 ` Fabien Lahoudere
0 siblings, 0 replies; 6+ messages in thread
From: Fabien Lahoudere @ 2016-10-06 8:01 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Mark Brown, linux-spi, linux-kernel
Hi,
On 30/09/16 19:35, Geert Uytterhoeven wrote:
> On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
> <fabien.lahoudere@collabora.co.uk> wrote:
>> Entries are needed in the spidev ID list to configure configure it from a
>> device tree. Add entries for the following devices:
>
>> - "exar,xra1403" : a GPIO expander
>
> Looks like a suitable target for a drivers/gpio/ driver.
> Datasheet available at
> https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403
>
Good idea, however we have to measure impact of this change on the project.
Thanks
Fabien
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-06 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30 10:15 [PATCH 1/1] Add devices to spidev device tree compatibility list Fabien Lahoudere
2016-09-30 16:08 ` Mark Brown
2016-10-06 14:44 ` [PATCH v2 1/1] Add device " Fabien Lahoudere
2016-10-06 14:49 ` Mark Brown
2016-09-30 17:35 ` [PATCH 1/1] Add devices " Geert Uytterhoeven
2016-10-06 8:01 ` Fabien Lahoudere
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®