Re: lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch removed from -mm tree

Re: lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch removed from -mm tree

[Éric Piel]

akpm@linux-foundation.org schreef:
> The patch titled
>      lis3lv02d: add axes knowledge of HP Pavilion dv5 models
> has been removed from the -mm tree.  Its filename was
>      lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch
> 
> This patch was dropped because an updated version will be merged

Hello Andrew,
With the patch "lis3lv02d: support both one- and two-byte sensors",
Giuseppe has confirmed that this patch is still correct. Would you mind
queuing it back for 2.6.29?

Palatis, if you could try this patch plus the patch "lis3lv02d: support
both one- and two-byte sensors" to confirm it does the right thing also
with your laptop, it would be great. Unfortunately, right now I think
they apply only on top of the -mm tree...

Thanks,
Eric


> ------------------------------------------------------
> Subject: lis3lv02d: add axes knowledge of HP Pavilion dv5 models
> From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> 
> Add support for HP Pavlion dv5 models, whose sensor has an inverted x
> axis.
> 
> My HP Pavilion dv5 has an inverted x axis of the accelerometer, so this
> patch marks the inversion for all the dv5.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> Acked-by: Eric Piel <Eric.Piel@tremplin-utc.net>
> Cc: Pavel Machek <pavel@suse.cz>
> Cc: Palatis Tseng <palatis@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/hwmon/hp_accel.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN drivers/hwmon/hp_accel.c~lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models drivers/hwmon/hp_accel.c
> --- a/drivers/hwmon/hp_accel.c~lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models
> +++ a/drivers/hwmon/hp_accel.c
> @@ -179,6 +179,7 @@ static struct dmi_system_id lis3lv02d_dm
>  	AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
>  	AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
>  	AXIS_DMI_MATCH("NC671xx", "HP Compaq 671", xy_swap_yz_inverted),
> +	AXIS_DMI_MATCH("HPDV5", "HP Pavilion dv5", x_inverted),
>  	{ NULL, }
>  /* Laptop models without axis info (yet):
>   * "NC6910" "HP Compaq 6910"

Re: lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch removed from -mm tree

[Giuseppe Bilotta]

On Wed, Feb 11, 2009 at 11:26 AM, Éric Piel <eric.piel@tremplin-utc.net> wrote:
> akpm@linux-foundation.org schreef:
>> The patch titled
>>      lis3lv02d: add axes knowledge of HP Pavilion dv5 models
>> has been removed from the -mm tree.  Its filename was
>>      lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch
>>
>> This patch was dropped because an updated version will be merged
>
> Hello Andrew,
> With the patch "lis3lv02d: support both one- and two-byte sensors",
> Giuseppe has confirmed that this patch is still correct. Would you mind
> queuing it back for 2.6.29?
>
> Palatis, if you could try this patch plus the patch "lis3lv02d: support
> both one- and two-byte sensors" to confirm it does the right thing also
> with your laptop, it would be great. Unfortunately, right now I think
> they apply only on top of the -mm tree...

It's possible to apply them on top of Linus' tree modulo Pavel's
"don't touch init" patch.

However, I think my patch might not be good for Palatis. If the
dmidecode that was posted some time earlier was his (don't recall
right now) I remember it being an AMD board, whereas I'm on an Intel
board, so we have different dv5 models and we probably need different
fixes, so I need to work out a better patch, but I'll need Palatis'
help testing it.

-- 
Giuseppe "Oblomov" Bilotta

Re: lis3lv02d-add-axes-knowledge-of-hp-pavilion-dv5-models.patch removed from -mm tree

[Giuseppe Bilotta]

On Wed, Feb 11, 2009 at 1:02 PM, Giuseppe Bilotta
<giuseppe.bilotta@gmail.com> wrote:
> On Wed, Feb 11, 2009 at 11:26 AM, Éric Piel <eric.piel@tremplin-utc.net> wrote:
>> Palatis, if you could try this patch plus the patch "lis3lv02d: support
>> both one- and two-byte sensors" to confirm it does the right thing also
>> with your laptop, it would be great. Unfortunately, right now I think
>> they apply only on top of the -mm tree...
>
> It's possible to apply them on top of Linus' tree modulo Pavel's
> "don't touch init" patch.
>
> However, I think my patch might not be good for Palatis. If the
> dmidecode that was posted some time earlier was his (don't recall
> right now) I remember it being an AMD board, whereas I'm on an Intel
> board, so we have different dv5 models and we probably need different
> fixes, so I need to work out a better patch, but I'll need Palatis'
> help testing it.

I took the liberty to publish my changes over at
http://git.oblomov.eu/linux-2.6/oblomov : the topmost commits of this
branch are (1) Pavel's no-init, (2) my one- and two-byte sensors
support (3) an attempt at supporting both intel and amd hpdv5.
Palatis, can you wget

http://git.oblomov.eu/linux-2.6/patches/1db8508cf483dc1ecf66141f90a7c03659d69512..oblomov

git am it, remake the hp_accel and lis3lv02d modules, and see if you
get proper directions for your laptop? If not, can you post your
dmidecode and the results of testing axis orientation without the last
patch?

-- 
Giuseppe "Oblomov" Bilotta