* [PATCH] x86: make 32bit to call enable_IO_APIC early like 64bit
@ 2009-02-15 7:57 Yinghai Lu
2009-02-15 8:01 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Yinghai Lu @ 2009-02-15 7:57 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Andrew Morton; +Cc: linux-kernel
Impact: cleanup
so remove some #ifdef
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/io_apic.c | 4 ----
arch/x86/kernel/smpboot.c | 3 +--
2 files changed, 1 insertion(+), 6 deletions(-)
Index: linux-2.6/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/io_apic.c
+++ linux-2.6/arch/x86/kernel/io_apic.c
@@ -3057,13 +3057,9 @@ out:
void __init setup_IO_APIC(void)
{
-#ifdef CONFIG_X86_32
- enable_IO_APIC();
-#else
/*
* calling enable_IO_APIC() is moved to setup_local_APIC for BP
*/
-#endif
io_apic_irqs = ~PIC_IRQS;
Index: linux-2.6/arch/x86/kernel/smpboot.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/smpboot.c
+++ linux-2.6/arch/x86/kernel/smpboot.c
@@ -1154,13 +1154,12 @@ void __init native_smp_prepare_cpus(unsi
*/
setup_local_APIC();
-#ifdef CONFIG_X86_64
/*
* Enable IO APIC before setting up error vector
*/
if (!skip_ioapic_setup && nr_ioapics)
enable_IO_APIC();
-#endif
+
end_local_APIC_setup();
map_cpu_to_logical_apicid();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: make 32bit to call enable_IO_APIC early like 64bit
2009-02-15 7:57 [PATCH] x86: make 32bit to call enable_IO_APIC early like 64bit Yinghai Lu
@ 2009-02-15 8:01 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-02-15 8:01 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Thomas Gleixner, H. Peter Anvin, Andrew Morton, linux-kernel
* Yinghai Lu <yinghai@kernel.org> wrote:
>
> Impact: cleanup
>
> so remove some #ifdef
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/kernel/io_apic.c | 4 ----
> arch/x86/kernel/smpboot.c | 3 +--
> 2 files changed, 1 insertion(+), 6 deletions(-)
Applied to tip:x86/apic, thanks Yinghai!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-15 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-15 7:57 [PATCH] x86: make 32bit to call enable_IO_APIC early like 64bit Yinghai Lu
2009-02-15 8:01 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®