From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: mingo@elte.hu, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/utsname_sysctl.c
Date: Mon, 16 Feb 2009 14:09:28 +0100 [thread overview]
Message-ID: <49996588.2040501@s5r6.in-berlin.de> (raw)
In-Reply-To: <ea11fea30902151039n447cc111medb9721a95af81a8@mail.gmail.com>
Manish Katiyar wrote:
> --- a/kernel/utsname_sysctl.c
> +++ b/kernel/utsname_sysctl.c
> @@ -49,7 +49,7 @@ static int proc_do_uts_string(ctl_table *table, int
> write, struct file *filp,
> int r;
> memcpy(&uts_table, table, sizeof(uts_table));
> uts_table.data = get_uts(table, write);
> - r = proc_dostring(&uts_table,write,filp,buffer,lenp, ppos);
> + r = proc_dostring(&uts_table, write, filp, buffer, lenp, ppos);
> put_uts(table, write, uts_table.data);
> return r;
> }
> @@ -142,4 +142,4 @@ static int __init utsname_sysctl_init(void)
> return 0;
> }
>
> -__initcall(utsname_sysctl_init);
> +device_initcall(utsname_sysctl_init);
The changelog should note that this is a whitespace fix + initcall
annotation change.
That checkpatch was somehow involved in the creation of this patch is
entirely uninteresting for the changelog.
--
Stefan Richter
-=====-==--= --=- =----
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-02-16 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 18:39 Manish Katiyar
2009-02-16 13:09 ` Stefan Richter [this message]
2009-02-16 14:59 ` Manish Katiyar
2009-02-16 15:34 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49996588.2040501@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®