From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: mingo@elte.hu, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/utsname_sysctl.c
Date: Mon, 16 Feb 2009 16:34:32 +0100 [thread overview]
Message-ID: <49998788.80606@s5r6.in-berlin.de> (raw)
In-Reply-To: <ea11fea30902160659q58578152gea3f4da3821c8e0c@mail.gmail.com>
Manish Katiyar wrote:
> On Mon, Feb 16, 2009 at 6:39 PM, Stefan Richter
> <stefanr@s5r6.in-berlin.de> wrote:
>> The changelog should note that this is a whitespace fix + initcall
>> annotation change.
Sorry, I didn't get the point of __initcall/device_initcall. It's not
an annotation; it defines a call sequence level.
> Replace deprecated __initcall with equivalent device_initcall. Also
> fix whitespaces.
...
> --- a/kernel/utsname_sysctl.c
> +++ b/kernel/utsname_sysctl.c
...
> @@ -142,4 +142,4 @@ static int __init utsname_sysctl_init(void)
> return 0;
> }
>
> -__initcall(utsname_sysctl_init);
> +device_initcall(utsname_sysctl_init);
It is equivalent, but is it also the most appropriate one?
--
Stefan Richter
-=====-=-=== -=-= -==-=
http://arcgraph.de/sr/
prev parent reply other threads:[~2009-02-16 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 18:39 Manish Katiyar
2009-02-16 13:09 ` Stefan Richter
2009-02-16 14:59 ` Manish Katiyar
2009-02-16 15:34 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49998788.80606@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®