Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables

[Jiri Slaby <jirislaby@kernel.org>]

On 13. 05. 22, 3:54, Zhang Jianhua wrote:
> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> been initialized but not used, they are redundant and remove them.
> 
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
> 
> ---
> No code changes since v1, only remove the redundant line "--------" in
> v1 commit message.
> ---
>   drivers/tty/vt/defkeymap.c_shipped | 4 ----

The file header says:
/* Do not edit this file! It was automatically generated by   */
/*    loadkeys --mktable defkeymap.map > defkeymap.c          */

So I'm not sure anyone wants to touch it.

> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -185,10 +185,6 @@ char func_buf[] = {
>   	'\033', '[', 'P', 0,
>   };
>   
> -char *funcbufptr = func_buf;
> -int funcbufsize = sizeof(func_buf);
> -int funcbufleft = 0;          /* space left */
> -
>   char *func_table[MAX_NR_FUNC] = {
>   	func_buf + 0,
>   	func_buf + 5,


-- 
js
suse labs