Re: [PATCH v2] arm64: dts: amlogic: meson-s4-s905y4-khadas-vim1s: enable SDIO interface

[neil.armstrong@linaro.org]

On 1/21/26 02:47, Nick Xie wrote:
> Enable the SDIO controller interface connected to the on-board
> AP6256 WiFi/BT module.
> 
> Signed-off-by: Nick Xie <nick@khadas.com>
> ---
> Changes in v2:
> - Dropped 'amlogic,dram-access-quirk' property as it is not required for S905Y4.
> - Updated compatible string to specific "brcm,bcm43456-fmac".
> - Link to v1: https://lore.kernel.org/all/20260116023900.2036657-1-nick@khadas.com/
> 
>   .../amlogic/meson-s4-s905y4-khadas-vim1s.dts  | 27 +++++++++++++++++++
>   1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
> index 4a66c1bec965e..27d0f6134ea9d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
> @@ -220,6 +220,33 @@ &sd {
>   	vqmmc-supply = <&vddio_sd>;
>   };
>   
> +&sdio {
> +	status = "okay";
> +	pinctrl-0 = <&sdio_pins>;
> +	pinctrl-1 = <&sdio_clk_gate_pins>;
> +	pinctrl-names = "default", "clk-gate";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	bus-width = <4>;
> +	cap-sd-highspeed;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;
> +	max-frequency = <50000000>;
> +	non-removable;
> +	disable-wp;
> +
> +	no-sd;
> +	no-mmc;
> +	mmc-pwrseq = <&sdio_pwrseq>;
> +	vmmc-supply = <&vddao_3v3>;
> +	vqmmc-supply = <&vddio_ao1v8>;
> +
> +	brcmf: wifi@1 {
> +		reg = <1>;
> +		compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-fmac";
> +	};
> +};
> +
>   &spicc0 {
>   	status = "okay";
>   	pinctrl-names = "default";

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil