* [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322
2024-12-20 7:00 [PATCH v2 0/4] Enable TRNG support Md Sadre Alam
@ 2024-12-20 7:00 ` Md Sadre Alam
2024-12-24 9:42 ` Krzysztof Kozlowski
2024-12-20 7:00 ` [PATCH v2 2/4] arm64: dts: qcom: ipq5424: add TRNG node Md Sadre Alam
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Md Sadre Alam @ 2024-12-20 7:00 UTC (permalink / raw)
To: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada, quic_mdalam
Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
Generator.
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
Change in [v2]
* Added device tree binding change
Change in [v1]
* This patch was not included in [v1]
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 2c959162e428..7ca1db52bbc5 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -24,6 +24,9 @@ properties:
- qcom,sm8450-trng
- qcom,sm8550-trng
- qcom,sm8650-trng
+ - qcom,ipq5332-trng
+ - qcom,ipq5424-trng
+ - qcom,ipq9574-trng
- const: qcom,trng
reg:
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322
2024-12-20 7:00 ` [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322 Md Sadre Alam
@ 2024-12-24 9:42 ` Krzysztof Kozlowski
2024-12-26 5:08 ` Md Sadre Alam
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-24 9:42 UTC (permalink / raw)
To: Md Sadre Alam
Cc: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
quic_mmanikan, quic_srichara, quic_varada
On Fri, Dec 20, 2024 at 12:30:33PM +0530, Md Sadre Alam wrote:
> Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
> Generator.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
>
> Change in [v2]
>
> * Added device tree binding change
>
> Change in [v1]
>
> * This patch was not included in [v1]
>
> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 2c959162e428..7ca1db52bbc5 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -24,6 +24,9 @@ properties:
> - qcom,sm8450-trng
> - qcom,sm8550-trng
> - qcom,sm8650-trng
> + - qcom,ipq5332-trng
> + - qcom,ipq5424-trng
> + - qcom,ipq9574-trng
Do not add new entries to the end of lists. Keep sorting.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322
2024-12-24 9:42 ` Krzysztof Kozlowski
@ 2024-12-26 5:08 ` Md Sadre Alam
0 siblings, 0 replies; 9+ messages in thread
From: Md Sadre Alam @ 2024-12-26 5:08 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
quic_mmanikan, quic_srichara, quic_varada
On 12/24/2024 3:12 PM, Krzysztof Kozlowski wrote:
> On Fri, Dec 20, 2024 at 12:30:33PM +0530, Md Sadre Alam wrote:
>> Document ipq9574, ipq5424 and ipq5322 compatible for the True Random Number
>> Generator.
>>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>>
>> Change in [v2]
>>
>> * Added device tree binding change
>>
>> Change in [v1]
>>
>> * This patch was not included in [v1]
>>
>> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 2c959162e428..7ca1db52bbc5 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -24,6 +24,9 @@ properties:
>> - qcom,sm8450-trng
>> - qcom,sm8550-trng
>> - qcom,sm8650-trng
>> + - qcom,ipq5332-trng
>> + - qcom,ipq5424-trng
>> + - qcom,ipq9574-trng
>
> Do not add new entries to the end of lists. Keep sorting.
Sure, Will do in next revision.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] arm64: dts: qcom: ipq5424: add TRNG node
2024-12-20 7:00 [PATCH v2 0/4] Enable TRNG support Md Sadre Alam
2024-12-20 7:00 ` [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322 Md Sadre Alam
@ 2024-12-20 7:00 ` Md Sadre Alam
2024-12-20 7:00 ` [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible Md Sadre Alam
2024-12-20 7:00 ` [PATCH v2 4/4] arm64: dts: qcom: ipq5332: " Md Sadre Alam
3 siblings, 0 replies; 9+ messages in thread
From: Md Sadre Alam @ 2024-12-20 7:00 UTC (permalink / raw)
To: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada, quic_mdalam
Add TRNG (Truly Random Number Generator) node for ipq5424
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
Change in [v2]
* Included Reviewed-by tag
* Updated commit heading from "Add TRNG node" to "add TRNG node".
* Changed "add TRNG" to "Add TRNG" in the commit message
* updated compatible string
Change in [v1]
* Submitted initial patche to activate TRNG for IPQ5424
arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 5e219f900412..aab1cf787863 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -145,6 +145,13 @@ soc@0 {
#size-cells = <2>;
ranges = <0 0 0 0 0x10 0>;
+ rng: rng@4c3000 {
+ compatible = "qcom,ipq5424-trng", "qcom,trng";
+ reg = <0 0x004c3000 0 0x1000>;
+ clocks = <&gcc GCC_PRNG_AHB_CLK>;
+ clock-names = "core";
+ };
+
tlmm: pinctrl@1000000 {
compatible = "qcom,ipq5424-tlmm";
reg = <0 0x01000000 0 0x300000>;
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible
2024-12-20 7:00 [PATCH v2 0/4] Enable TRNG support Md Sadre Alam
2024-12-20 7:00 ` [PATCH v2 1/4] dt-bindings: crypto: qcom,prng: document ipq9574, ipq5424 and ipq5322 Md Sadre Alam
2024-12-20 7:00 ` [PATCH v2 2/4] arm64: dts: qcom: ipq5424: add TRNG node Md Sadre Alam
@ 2024-12-20 7:00 ` Md Sadre Alam
2024-12-20 9:46 ` Konrad Dybcio
2024-12-20 7:00 ` [PATCH v2 4/4] arm64: dts: qcom: ipq5332: " Md Sadre Alam
3 siblings, 1 reply; 9+ messages in thread
From: Md Sadre Alam @ 2024-12-20 7:00 UTC (permalink / raw)
To: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada, quic_mdalam
RNG hardware versions greater than 3.0 are Truly Random Number
Generators (TRNG). In IPQ9574, the RNGblock is a TRNG.
This patch corrects the compatible property which correctly describes
the hardware without making any functional changes
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
Change in [v2]
* Revised the commit message
* Changed IPQ95xx to IPQ9574 in the commit message
* updated compatible string
Change in [v1]
* Submitted initial patche to activate TRNG
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index d1fd35ebc4a2..453574c370f1 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -227,7 +227,7 @@ rpm_msg_ram: sram@60000 {
};
rng: rng@e3000 {
- compatible = "qcom,prng-ee";
+ compatible = "qcom,ipq9574-trng", "qcom,trng";
reg = <0x000e3000 0x1000>;
clocks = <&gcc GCC_PRNG_AHB_CLK>;
clock-names = "core";
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible
2024-12-20 7:00 ` [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible Md Sadre Alam
@ 2024-12-20 9:46 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-12-20 9:46 UTC (permalink / raw)
To: Md Sadre Alam, herbert, davem, robh, krzk+dt, conor+dt,
andersson, konradybcio, linux-arm-msm, linux-crypto, devicetree,
linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada
On 20.12.2024 8:00 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly Random Number
> Generators (TRNG). In IPQ9574, the RNGblock is a TRNG.
>
> This patch corrects the compatible property which correctly describes
> the hardware without making any functional changes
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: ipq5332: update TRNG compatible
2024-12-20 7:00 [PATCH v2 0/4] Enable TRNG support Md Sadre Alam
` (2 preceding siblings ...)
2024-12-20 7:00 ` [PATCH v2 3/4] arm64: dts: qcom: ipq9574: update TRNG compatible Md Sadre Alam
@ 2024-12-20 7:00 ` Md Sadre Alam
2024-12-20 9:46 ` Konrad Dybcio
3 siblings, 1 reply; 9+ messages in thread
From: Md Sadre Alam @ 2024-12-20 7:00 UTC (permalink / raw)
To: herbert, davem, robh, krzk+dt, conor+dt, andersson, konradybcio,
linux-arm-msm, linux-crypto, devicetree, linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada, quic_mdalam
RNG hardware versions greater than 3.0 are Truly Random Number
Generators (TRNG). In IPQ5332, the RNGblock is a TRNG.
This patch corrects the compatible property which correctly describes
the hardware without making any functional changes
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
Change in [v2]
* Revised the commit message
* updated compatible string
Change in [v1]
* Submitted initial patche to activate TRNG
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index d3c3e215a15c..ca3da95730bd 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -180,7 +180,7 @@ cpu_speed_bin: cpu-speed-bin@1d {
};
rng: rng@e3000 {
- compatible = "qcom,prng-ee";
+ compatible = "qcom,ipq5332-trng", "qcom,trng";
reg = <0x000e3000 0x1000>;
clocks = <&gcc GCC_PRNG_AHB_CLK>;
clock-names = "core";
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: ipq5332: update TRNG compatible
2024-12-20 7:00 ` [PATCH v2 4/4] arm64: dts: qcom: ipq5332: " Md Sadre Alam
@ 2024-12-20 9:46 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-12-20 9:46 UTC (permalink / raw)
To: Md Sadre Alam, herbert, davem, robh, krzk+dt, conor+dt,
andersson, konradybcio, linux-arm-msm, linux-crypto, devicetree,
linux-kernel
Cc: quic_mmanikan, quic_srichara, quic_varada
On 20.12.2024 8:00 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly Random Number
> Generators (TRNG). In IPQ5332, the RNGblock is a TRNG.
>
> This patch corrects the compatible property which correctly describes
> the hardware without making any functional changes
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread