* [PATCH] net/mlx5: handle errors in mlx5_chains_create_table()
@ 2025-03-04 8:03 Wentao Liang
2025-03-05 19:12 ` Tariq Toukan
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2025-03-04 8:03 UTC (permalink / raw)
To: saeedm, leon, tariqt, andrew+netdev, davem, edumazet, kuba, pabeni
Cc: netdev, linux-rdma, linux-kernel, Wentao Liang
Add error handling for mlx5_get_fdb_sub_ns() and
mlx5_get_flow_namespace() failures in mlx5_chains_create_table().
Log error message with mlx5_core_warn() to prevent silent failures
and return immediately to prevent null pointer dereference of ns.
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
index a80ecb672f33..e808531cc6f5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
@@ -196,6 +196,11 @@ mlx5_chains_create_table(struct mlx5_fs_chains *chains,
ns = mlx5_get_flow_namespace(chains->dev, chains->ns);
}
+ if (!ns) {
+ mlx5_core_warn(chains->dev, "Failed to get flow namespace\n");
+ return NULL;
+ }
+
ft_attr.autogroup.num_reserved_entries = 2;
ft_attr.autogroup.max_num_groups = chains->group_num;
ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);
--
2.42.0.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx5: handle errors in mlx5_chains_create_table()
2025-03-04 8:03 [PATCH] net/mlx5: handle errors in mlx5_chains_create_table() Wentao Liang
@ 2025-03-05 19:12 ` Tariq Toukan
0 siblings, 0 replies; 2+ messages in thread
From: Tariq Toukan @ 2025-03-05 19:12 UTC (permalink / raw)
To: Wentao Liang, saeedm, leon, tariqt, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: netdev, linux-rdma, linux-kernel
On 04/03/2025 10:03, Wentao Liang wrote:
> Add error handling for mlx5_get_fdb_sub_ns() and
> mlx5_get_flow_namespace() failures in mlx5_chains_create_table().
> Log error message with mlx5_core_warn() to prevent silent failures
nit: double spaces before mlx5_core_warn.
> and return immediately to prevent null pointer dereference of ns.
>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Please add Fixes tag and target the patch to net.
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> index a80ecb672f33..e808531cc6f5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> @@ -196,6 +196,11 @@ mlx5_chains_create_table(struct mlx5_fs_chains *chains,
> ns = mlx5_get_flow_namespace(chains->dev, chains->ns);
> }
>
> + if (!ns) {
> + mlx5_core_warn(chains->dev, "Failed to get flow namespace\n");
> + return NULL;
Callers expect error, not NULL.
> + }
> +
> ft_attr.autogroup.num_reserved_entries = 2;
> ft_attr.autogroup.max_num_groups = chains->group_num;
> ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-05 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 8:03 [PATCH] net/mlx5: handle errors in mlx5_chains_create_table() Wentao Liang
2025-03-05 19:12 ` Tariq Toukan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®