mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: David Miller <davem@davemloft.net>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-hotplug@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, fenlason@redhat.com
Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name
Date: Thu, 21 May 2009 22:13:50 +0200	[thread overview]
Message-ID: <4A15B5FE.3070207@s5r6.in-berlin.de> (raw)
In-Reply-To: <20090521.123403.13286908.davem@davemloft.net>

David Miller wrote:
> From: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Date: Thu, 21 May 2009 15:29:10 +0200 (CEST)
>> Change the initial name of IP-over-1394 networking interfaces from
>> "eth[0-9]+" to "firewire[0-9]+".
...
> I think the basis for this patch is completely bogus.
> 
> Device names are just that, names.  If you want to know "what it is"
> or "where it is" you use tools to determine that information.
> 
> If you make ethtool's get info command return something useful,
> then the user can see that it's a firewire interface and act
> accordingly, as can sophisticated confiruation applications.
> 
> I am completely against this patch.

Ethtool shows:
	driver: eth1394
	version:
	firmware-version:
	bus-info: ieee1394
And the sysfs representations of the netdevices have an fw-host* device 
in the parent device chain.

I agree that userland should read less into names as they are handed out 
by the kernel.  I am also aware that it depends on the use case what 
naming scheme can be considered useful, hence userspace needs to give 
his own names anyway, regardless of how the kernel named it.

But I mildly disagree with the notion that the kernel can't start off 
with more qualification of the names than merely ensuring their 
uniqueness.  Or the other way around:  Even an entirely meaningless 
prefix would be better than "eth..", or no prefix if that's possible, 
because eth suspiciously sounds like Ethernet with which the misnamed 
RFC 2734 driver eth1394 has very little to do.

However, how mild my disagreement is should be apparent from the fact 
that I didn't bother to suggest changing it before now, in 2009. :-)
-- 
Stefan Richter
-=====-=-=== -=-= -==-=
http://arcgraph.de/sr/

  reply	other threads:[~2009-05-21 20:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 13:29 Stefan Richter
2009-05-21 13:48 ` Jiri Pirko
2009-05-21 14:31   ` Stefan Richter
2009-05-21 16:43     ` Kay Sievers
2009-05-24  6:13     ` Christian Kujau
2009-05-24  9:47       ` Stefan Richter
2009-05-25  8:33         ` Matthias Schwarzott
2009-05-25 10:43           ` Stefan Richter
2009-05-25 10:57           ` Kay Sievers
2009-05-21 19:34 ` David Miller
2009-05-21 20:13   ` Stefan Richter [this message]
2009-05-21 20:33     ` David Miller
2009-05-21 21:35       ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A15B5FE.3070207@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=davem@davemloft.net \
    --cc=fenlason@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®