mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Joe Perches <joe@perches.com>
Cc: acpi4asus-user@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>,
	Len Brown <len.brown@intel.com>,
	Corentin Chary <corentincj@iksaif.net>,
	Matthew Garrett <mjg@redhat.com>,
	Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr_<level>
Date: Fri, 05 Jun 2009 11:54:02 +0100	[thread overview]
Message-ID: <4A28F94A.6040500@tuffmail.co.uk> (raw)
In-Reply-To: <1244197103.3631.40.camel@Joe-Laptop.home>

Joe Perches wrote:
> Convert the unusual printk(EEEPC_<level> uses to
> the more standard pr_fmt and pr_<level>(.
>
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 353a898..94cacdd 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -16,6 +16,8 @@
>   *  GNU General Public License for more details.
>   */
>  
> +#define pr_fmt(fmt) EEEPC_HOTK_FILE ": " fmt
>
>   

Is EEEPC_HOTK_FILE used anywhere else?  It would be clearer if you were 
able to just use "eeepc: " or whatever and remove the definition of 
EEEPC_HOTK_FILE.

Thanks for the cleanup
Alan


  reply	other threads:[~2009-06-05 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05 10:18 Joe Perches
2009-06-05 10:54 ` Alan Jenkins [this message]
2009-06-05 11:00   ` Joe Perches
2009-06-05 11:57     ` Corentin Chary
2009-06-05 15:45       ` Joe Perches
2009-06-05 16:01         ` Corentin Chary
2009-06-05 16:07           ` Joe Perches
2009-06-05 16:15             ` Corentin Chary
2009-06-05 11:59 ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A28F94A.6040500@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentincj@iksaif.net \
    --cc=joe@perches.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@youmustbejoking.demon.co.uk \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®