From: Corentin Chary <corentin.chary@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
acpi4asus-user@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Matthew Garrett <mjg@redhat.com>,
Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr_<level>
Date: Fri, 5 Jun 2009 18:01:16 +0200 [thread overview]
Message-ID: <71cd59b00906050901p71c7483fja5b3c74744f93384@mail.gmail.com> (raw)
In-Reply-To: <1244216712.3631.117.camel@Joe-Laptop.home>
On Fri, Jun 5, 2009 at 5:45 PM, Joe Perches<joe@perches.com> wrote:
> On Fri, 2009-06-05 at 13:57 +0200, Corentin Chary wrote:
>> On Fri, Jun 5, 2009 at 1:00 PM, Joe Perches<joe@perches.com> wrote:
>> > On Fri, 2009-06-05 at 11:54 +0100, Alan Jenkins wrote:
>> >> Is EEEPC_HOTK_FILE used anywhere else? It would be clearer if you were
>> >> able to just use "eeepc: " or whatever and remove the definition of
>> >> EEEPC_HOTK_FILE.
>> > It is used elsewhere and perhaps it'd be better to use KBUILD_MODNAME.
>> I think we can't use KBUILD_MODNAME because "eeepc" is used for
>> platform_device, backlight and input device. Using "eeepc-laptop"
>> would break compatibility.
>
> What compatibility would it break?
> Logging messages are not guaranteed to be stable across versions.
for platform_device backlight and input device it would change the
"/sys" paths (eg: /sys/class/backlight/eeepc)
Thanks for the patch, will be applied soon =)
--
Corentin Chary
http://xf.iksaif.net - http://uffs.org
next prev parent reply other threads:[~2009-06-05 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 10:18 Joe Perches
2009-06-05 10:54 ` Alan Jenkins
2009-06-05 11:00 ` Joe Perches
2009-06-05 11:57 ` Corentin Chary
2009-06-05 15:45 ` Joe Perches
2009-06-05 16:01 ` Corentin Chary [this message]
2009-06-05 16:07 ` Joe Perches
2009-06-05 16:15 ` Corentin Chary
2009-06-05 11:59 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cd59b00906050901p71c7483fja5b3c74744f93384@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@youmustbejoking.demon.co.uk \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®