From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: akpm@linux-foundation.org, bblum@andrew.cmu.edu,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869
Date: Thu, 20 Aug 2009 11:11:24 +0800 [thread overview]
Message-ID: <4A8CBEDC.6010709@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830908191941x6ee47d58x295c29f80f8c624c@mail.gmail.com>
Paul Menage wrote:
> On Wed, Aug 19, 2009 at 7:34 PM, Li Zefan<lizf@cn.fujitsu.com> wrote:
>> It's sure that reverting this commit makes things easier, but
>> rebasing this patchset shouldn't be hard. And this doesn't
>> sound a good reason to revert an innocent commit.
>>
>
> The problem is that Ben's patch set starts with a patch that adds the
> "procs" file, and then a patch that fixes the namespace bug, and he
> and you used different names for variables/functions even though you
> were doing essentially the same thing. So rebasing would involve
> pretty much entirely rewriting the first patch and ditching the second
> - not just a case of fixing up some merge conflicts.
>
Here we reintroduce the bug, and re-fix it with the essentially
same solution, this lazy way doesn't sound right to me.
As you said, the 2 patches differ just in using different var/func
names, so rebasing shouldn't be hard but maybe a bit boring.
next prev parent reply other threads:[~2009-08-20 3:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 23:58 [PATCH 0/8] CGroups: cgroup memberlist enhancements/fixes Paul Menage
2009-08-18 23:58 ` [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869 Paul Menage
2009-08-20 2:34 ` Li Zefan
2009-08-20 2:41 ` Paul Menage
2009-08-20 3:11 ` Li Zefan [this message]
2009-08-20 3:13 ` Paul Menage
2009-08-20 3:17 ` Li Zefan
2009-08-20 4:40 ` Matt Helsley
2009-08-20 4:49 ` Paul Menage
2009-08-20 21:13 ` Andrew Morton
2009-08-18 23:58 ` [PATCH 2/8] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Paul Menage
2009-08-20 2:34 ` Li Zefan
2009-08-18 23:58 ` [PATCH 3/8] Ensures correct concurrent opening/reading of pidlists across pid namespaces Paul Menage
2009-08-18 23:58 ` [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations Paul Menage
2009-08-20 2:37 ` Li Zefan
2009-08-20 2:41 ` Paul Menage
2009-08-20 2:54 ` Li Zefan
2009-08-20 3:04 ` Paul Menage
2009-08-20 21:14 ` Andrew Morton
2009-08-20 22:35 ` Jonathan Corbet
2009-08-20 22:56 ` David Rientjes
2009-08-21 0:53 ` Li Zefan
2009-08-18 23:58 ` [PATCH 5/8] Changes css_set freeing mechanism to be under RCU Paul Menage
2009-08-20 2:38 ` Li Zefan
2009-08-18 23:58 ` [PATCH 6/8] Lets ss->can_attach and ss->attach do whole threadgroups at a time Paul Menage
2009-08-20 3:06 ` Li Zefan
2009-08-20 4:38 ` Matt Helsley
2009-08-18 23:58 ` [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup Paul Menage
2009-08-20 2:39 ` Li Zefan
2009-08-20 2:45 ` Paul Menage
2009-08-20 21:13 ` Andrew Morton
2009-08-20 21:16 ` Paul Menage
2009-08-21 4:24 ` Ben Blum
2009-08-21 4:50 ` Andrew Morton
2009-08-21 4:58 ` Paul Menage
2009-08-18 23:58 ` [PATCH 8/8] Adds ability to move all threads in a process to a new cgroup atomically Paul Menage
2009-08-20 3:00 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8CBEDC.6010709@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@andrew.cmu.edu \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome