From: Paul Menage <menage@google.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, bblum@andrew.cmu.edu,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations
Date: Wed, 19 Aug 2009 20:04:28 -0700 [thread overview]
Message-ID: <6599ad830908192004k5ea7b7a8y575d403113f126a8@mail.gmail.com> (raw)
In-Reply-To: <4A8CBAE1.9010408@cn.fujitsu.com>
On Wed, Aug 19, 2009 at 7:54 PM, Li Zefan<lizf@cn.fujitsu.com> wrote:
>
> To avoid showing duplicate threadgroup pids, when dealing with a
> thread, you have to check backwards to see if it's group pid
> has been printed. Maybe it doesn't add much extra cost with your
> proposal, we'll see.
My thought was to explicitly specify the output of cgroup.procs as
"mostly unique" and leave it up to userspace to make it really unique
if necessary. Then we can just skip the tgid if it's the same as the
previous one, and that will give you a unique list in the common case.
Paul
next prev parent reply other threads:[~2009-08-20 3:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 23:58 [PATCH 0/8] CGroups: cgroup memberlist enhancements/fixes Paul Menage
2009-08-18 23:58 ` [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869 Paul Menage
2009-08-20 2:34 ` Li Zefan
2009-08-20 2:41 ` Paul Menage
2009-08-20 3:11 ` Li Zefan
2009-08-20 3:13 ` Paul Menage
2009-08-20 3:17 ` Li Zefan
2009-08-20 4:40 ` Matt Helsley
2009-08-20 4:49 ` Paul Menage
2009-08-20 21:13 ` Andrew Morton
2009-08-18 23:58 ` [PATCH 2/8] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Paul Menage
2009-08-20 2:34 ` Li Zefan
2009-08-18 23:58 ` [PATCH 3/8] Ensures correct concurrent opening/reading of pidlists across pid namespaces Paul Menage
2009-08-18 23:58 ` [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations Paul Menage
2009-08-20 2:37 ` Li Zefan
2009-08-20 2:41 ` Paul Menage
2009-08-20 2:54 ` Li Zefan
2009-08-20 3:04 ` Paul Menage [this message]
2009-08-20 21:14 ` Andrew Morton
2009-08-20 22:35 ` Jonathan Corbet
2009-08-20 22:56 ` David Rientjes
2009-08-21 0:53 ` Li Zefan
2009-08-18 23:58 ` [PATCH 5/8] Changes css_set freeing mechanism to be under RCU Paul Menage
2009-08-20 2:38 ` Li Zefan
2009-08-18 23:58 ` [PATCH 6/8] Lets ss->can_attach and ss->attach do whole threadgroups at a time Paul Menage
2009-08-20 3:06 ` Li Zefan
2009-08-20 4:38 ` Matt Helsley
2009-08-18 23:58 ` [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup Paul Menage
2009-08-20 2:39 ` Li Zefan
2009-08-20 2:45 ` Paul Menage
2009-08-20 21:13 ` Andrew Morton
2009-08-20 21:16 ` Paul Menage
2009-08-21 4:24 ` Ben Blum
2009-08-21 4:50 ` Andrew Morton
2009-08-21 4:58 ` Paul Menage
2009-08-18 23:58 ` [PATCH 8/8] Adds ability to move all threads in a process to a new cgroup atomically Paul Menage
2009-08-20 3:00 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830908192004k5ea7b7a8y575d403113f126a8@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@andrew.cmu.edu \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®