From: Jeff Garzik <jeff@garzik.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
htejun@gmail.com, bzolnier@gmail.com, alan@lxorguk.ukuu.org.uk,
akpm@linux-foundation.org
Subject: Re: [PATCH 4/7] libata: use lazy workqueues for the pio task
Date: Mon, 24 Aug 2009 12:32:01 -0400 [thread overview]
Message-ID: <4A92C081.50207@garzik.org> (raw)
In-Reply-To: <1251100616-28604-5-git-send-email-jens.axboe@oracle.com>
On 08/24/2009 03:56 AM, Jens Axboe wrote:
> Signed-off-by: Jens Axboe<jens.axboe@oracle.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 072ba5e..35f74c9 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6580,7 +6580,7 @@ static int __init ata_init(void)
> {
> ata_parse_force_param();
>
> - ata_wq = create_workqueue("ata");
> + ata_wq = create_lazy_workqueue("ata");
> if (!ata_wq)
> goto free_force_tbl;
No objections to the code, operationally...
But it is disappointing that the "1 thread on UP" problem is not solved
while changing this libata area. Is there no way to specify a minimum
lazy-thread count?
A key problem continues to be tying to the number of CPUs, which is
quite inappropriate for libata.
Jeff
next prev parent reply other threads:[~2009-08-24 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 7:56 [PATCH 0/7] Lazy workqueues v2 Jens Axboe
2009-08-24 7:56 ` [PATCH 1/7] workqueue: replace singlethread/freezable/rt parameters and variables with flags Jens Axboe
2009-08-24 7:56 ` [PATCH 2/7] workqueue: add support for lazy workqueues Jens Axboe
2009-08-24 7:56 ` [PATCH 3/7] crypto: use " Jens Axboe
2009-08-24 7:56 ` [PATCH 4/7] libata: use lazy workqueues for the pio task Jens Axboe
2009-08-24 16:32 ` Jeff Garzik [this message]
2009-08-24 16:42 ` Jens Axboe
2009-08-24 16:51 ` Jeff Garzik
2009-08-24 18:16 ` Jens Axboe
2009-08-24 16:45 ` John Stoffel
2009-08-24 16:52 ` Jeff Garzik
2009-08-24 7:56 ` [PATCH 5/7] aio: use lazy workqueues Jens Axboe
2009-08-24 7:56 ` [PATCH 6/7] sunrpc: " Jens Axboe
2009-08-24 7:56 ` [PATCH 7/7] bio: convert integrity to " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A92C081.50207@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome