* [PATCH] xenfb: connect to backend before registering fb
@ 2009-08-27 19:22 Jeremy Fitzhardinge
2009-08-28 9:12 ` [Xen-devel] " Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2009-08-27 19:22 UTC (permalink / raw)
To: Linus Torvalds
Cc: Linux Kernel Mailing List, Michal Schmidt, Rafael J. Wysocki, Xen-devel
As soon as the framebuffer is registered, our methods may be called by the
kernel. This leads to a crash as xenfb_refresh() gets called before we have
the irq.
Connect to the backend before registering our framebuffer with the kernel.
[ Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14059 ]
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
index 15502d5..54cd916 100644
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -454,6 +454,10 @@ static int __devinit xenfb_probe(struct xenbus_device *dev,
xenfb_init_shared_page(info, fb_info);
+ ret = xenfb_connect_backend(dev, info);
+ if (ret < 0)
+ goto error;
+
ret = register_framebuffer(fb_info);
if (ret) {
fb_deferred_io_cleanup(fb_info);
@@ -464,10 +468,6 @@ static int __devinit xenfb_probe(struct xenbus_device *dev,
}
info->fb_info = fb_info;
- ret = xenfb_connect_backend(dev, info);
- if (ret < 0)
- goto error;
-
xenfb_make_preferred_console();
return 0;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] xenfb: connect to backend before registering fb
2009-08-27 19:22 [PATCH] xenfb: connect to backend before registering fb Jeremy Fitzhardinge
@ 2009-08-28 9:12 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2009-08-28 9:12 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Linus Torvalds, Rafael J. Wysocki, Xen-devel, Michal Schmidt,
Linux Kernel Mailing List
Jeremy Fitzhardinge <jeremy@goop.org> writes:
> As soon as the framebuffer is registered, our methods may be called by the
> kernel. This leads to a crash as xenfb_refresh() gets called before we have
> the irq.
>
> Connect to the backend before registering our framebuffer with the kernel.
>
> [ Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14059 ]
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Looks good to me.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xenfb: connect to backend before registering fb
2009-08-21 22:45 ` Jeremy Fitzhardinge
@ 2009-08-23 19:32 ` Michal Schmidt
0 siblings, 0 replies; 5+ messages in thread
From: Michal Schmidt @ 2009-08-23 19:32 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Mark McLoughlin, linux-kernel
Dne Fri, 21 Aug 2009 15:45:38 -0700 Jeremy Fitzhardinge napsal(a):
> On 08/21/09 06:44, Michal Schmidt wrote:
> > As soon as the framebuffer is registered, our methods may be called
> > by the kernel. This leads to a crash as xenfb_refresh() gets called
> > before we have the irq.
> >
> > Connect to the backend before registering our framebuffer with the
> > kernel.
>
> Thanks, applied. Should this be backported to stable?
Yes, it should go to stable too. 2.6.30.x needs it and it applies
cleanly.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xenfb: connect to backend before registering fb
2009-08-21 13:44 ` [PATCH] xenfb: connect to backend before registering fb Michal Schmidt
@ 2009-08-21 22:45 ` Jeremy Fitzhardinge
2009-08-23 19:32 ` Michal Schmidt
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2009-08-21 22:45 UTC (permalink / raw)
To: Michal Schmidt; +Cc: Mark McLoughlin, linux-kernel
On 08/21/09 06:44, Michal Schmidt wrote:
> As soon as the framebuffer is registered, our methods may be called by the
> kernel. This leads to a crash as xenfb_refresh() gets called before we have
> the irq.
>
> Connect to the backend before registering our framebuffer with the kernel.
>
Thanks, applied. Should this be backported to stable?
J
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] xenfb: connect to backend before registering fb
2009-08-21 13:13 ` Michal Schmidt
@ 2009-08-21 13:44 ` Michal Schmidt
2009-08-21 22:45 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Michal Schmidt @ 2009-08-21 13:44 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Mark McLoughlin, linux-kernel
As soon as the framebuffer is registered, our methods may be called by the
kernel. This leads to a crash as xenfb_refresh() gets called before we have
the irq.
Connect to the backend before registering our framebuffer with the kernel.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
--
Index: linux-git/drivers/video/xen-fbfront.c
===================================================================
--- linux-git.orig/drivers/video/xen-fbfront.c
+++ linux-git/drivers/video/xen-fbfront.c
@@ -454,6 +454,10 @@ static int __devinit xenfb_probe(struct
xenfb_init_shared_page(info, fb_info);
+ ret = xenfb_connect_backend(dev, info);
+ if (ret < 0)
+ goto error;
+
ret = register_framebuffer(fb_info);
if (ret) {
fb_deferred_io_cleanup(fb_info);
@@ -464,10 +468,6 @@ static int __devinit xenfb_probe(struct
}
info->fb_info = fb_info;
- ret = xenfb_connect_backend(dev, info);
- if (ret < 0)
- goto error;
-
xenfb_make_preferred_console();
return 0;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-28 9:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-27 19:22 [PATCH] xenfb: connect to backend before registering fb Jeremy Fitzhardinge
2009-08-28 9:12 ` [Xen-devel] " Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2009-08-21 10:40 DomU crashes during xenfb initialization Michal Schmidt
2009-08-21 13:09 ` Michal Schmidt
2009-08-21 13:13 ` Michal Schmidt
2009-08-21 13:44 ` [PATCH] xenfb: connect to backend before registering fb Michal Schmidt
2009-08-21 22:45 ` Jeremy Fitzhardinge
2009-08-23 19:32 ` Michal Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome