From: Ian Molton <ian.molton@collabora.co.uk>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
jeff@garzik.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: rng updates
Date: Sat, 28 Nov 2009 00:51:40 +0000 [thread overview]
Message-ID: <4B10741C.9090305@collabora.co.uk> (raw)
In-Reply-To: <1259362496.25403.165.camel@calx>
Matt Mackall wrote:
> On Thu, 2009-11-26 at 11:48 +0000, Ian Molton wrote:
>> Matt Mackall wrote:
>>> On Thu, 2009-11-26 at 10:49 +0000, Ian Molton wrote:
>>>> Hi guys,
>>>>
>>> No need to pass rng_buffer to the helper as there's only one with global
>>> scope.
>> Ah, sorry, I see what you mean now. The logic behind that is that it
>> matches the new API, whcih is all that will be left once the old drivers
>> are patched to use it. I planned to drop the helper altogether at that
>> point and though it'd make the patch more readable when that happens.
>
> Ok, that's quite reasonable.
>
>> Is this enough to get an acked-by: ? If so, I'll do that and see about
>> getting the change into linux-next.
>
> Acked-by: Matt Mackall <mpm@selenic.com>
Just to check - is that with or without changing the helpers parameters?
> You should probably go through Herbert's tree to get into -next,
> hopefully he won't be too miffed by your repeated failure to cc:
> linux-kernel initially and failure to cc: him here..
Drat, I thought he'd been re-added when LKML got added to the CC: list.
Sorry about that. Re-added to CC:
-Ian
next prev parent reply other threads:[~2009-11-28 0:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B080621.5000109@collabora.co.uk>
[not found] ` <4B0C18B0.2000206@collabora.co.uk>
[not found] ` <1259084901.17871.624.camel@calx>
[not found] ` <200911251135.41871.rusty@rustcorp.com.au>
[not found] ` <4B0D03FC.40406@collabora.co.uk>
2009-11-25 19:27 ` hw_random fixes Matt Mackall
2009-11-25 20:43 ` Ian Molton
2009-11-26 0:25 ` Ian Molton
2009-11-26 0:25 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Ian Molton
2009-11-26 0:25 ` [PATCH 2/2] virtio: Convert virtio-rng to the new API Ian Molton
2009-11-28 10:00 ` Rusty Russell
2009-11-30 9:55 ` Ian Molton
2009-11-26 1:03 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Matt Mackall
2009-11-26 10:49 ` Ian Molton
2009-11-26 10:49 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Ian Molton
2009-11-26 11:38 ` Matt Mackall
2009-11-26 11:48 ` Re: Ian Molton
2009-11-27 22:54 ` Re: Matt Mackall
2009-11-28 0:51 ` Ian Molton [this message]
2009-11-28 10:05 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Rusty Russell
2009-11-30 10:28 ` Ian Molton
2009-11-30 18:44 ` Matt Mackall
2009-12-01 3:08 ` Rusty Russell
2009-12-01 9:23 ` Ian Molton
2009-12-01 9:18 ` Ian Molton
2009-11-26 3:12 ` Jeff Garzik
2009-11-26 0:44 ` Ian Molton
2009-11-26 0:44 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Ian Molton
2009-11-26 0:44 ` [PATCH 2/2] virtio: Convert virtio-rng to the new API Ian Molton
2009-11-30 10:38 ` hw_random update Ian Molton
2009-11-30 10:38 ` [PATCH 1/2] hw_random: core updates to allow more efficient drivers Ian Molton
2009-11-30 10:38 ` [PATCH 2/2] virtio: Convert virtio-rng to the new API Ian Molton
2009-12-01 7:27 ` Herbert Xu
2009-12-01 9:29 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B10741C.9090305@collabora.co.uk \
--to=ian.molton@collabora.co.uk \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox