linux-next: input tree build failure

linux-next: input tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi Dmitry,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/input/sparse-keymap.c:101: error: __ksymtab_sparse_keymap_setkeycode causes a section type conflict

Caused by commit a2dd9f7ceeb28f495587834aa5778c721611d61b ("Input: add
generic support for sparse keymaps").

static functions should not given to EXPORT_SYMBOL().

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: input tree build failure

[Randy Dunlap]

Stephen Rothwell wrote:
> Hi Dmitry,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/input/sparse-keymap.c:101: error: __ksymtab_sparse_keymap_setkeycode causes a section type conflict
> 
> Caused by commit a2dd9f7ceeb28f495587834aa5778c721611d61b ("Input: add
> generic support for sparse keymaps").
> 
> static functions should not given to EXPORT_SYMBOL().
> 
> I have reverted that commit for today.

(DT:) Is that what causes wistron_btns builds to fail also?

-- 
~Randy

Re: linux-next: input tree build failure

[Dmitry Torokhov]

On Mon, Dec 07, 2009 at 08:25:36AM -0800, Randy Dunlap wrote:
> Stephen Rothwell wrote:
> > Hi Dmitry,
> > 
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > drivers/input/sparse-keymap.c:101: error: __ksymtab_sparse_keymap_setkeycode causes a section type conflict
> > 
> > Caused by commit a2dd9f7ceeb28f495587834aa5778c721611d61b ("Input: add
> > generic support for sparse keymaps").
> > 
> > static functions should not given to EXPORT_SYMBOL().
> > 
> > I have reverted that commit for today.
> 
> (DT:) Is that what causes wistron_btns builds to fail also?
> 

Umm... Wistron and dm355evm_keys now using sparse keymap library so if
it is missing they would fail to compile.

I removed the stray EXPORT_SYMBOL(), shold be good now.

-- 
Dmitry

Re: linux-next: input tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

Hi Dmitry,

On Mon, 7 Dec 2009 09:36:41 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> I removed the stray EXPORT_SYMBOL(), shold be good now.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: input tree build failure

[Tobias Klauser]

On 2010-01-25 at 07:46:03 +0100, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Mon, Jan 25, 2010 at 04:52:19PM +1100, Stephen Rothwell wrote:
> > Hi Dmitry,
> > 
> > Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
> > 
> > drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> > drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
> > include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> > drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
> > drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
> > include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> > 
> > Please at least build test this stuff ...
> > 
> > Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
> > xilinx_ps2 - use resource_size").
> > 
> > I have reverted that commit for today.
> > 
> 
> Argh, sorry about that. I adjusted the commit; John, Tobias, please
> verify (next branch in my tree).

Sorry, that was completely my fault. I didn't have the appropriate build
environment to at least build test it.

The adjusted commit looks fine to me.

Sorry again,
Tobias

Re: linux-next: input tree build failure

[Dmitry Torokhov]

On Mon, Jan 25, 2010 at 04:52:19PM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
> 
> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
> include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
> drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
> include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> 
> Please at least build test this stuff ...
> 
> Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
> xilinx_ps2 - use resource_size").
> 
> I have reverted that commit for today.
> 

Argh, sorry about that. I adjusted the commit; John, Tobias, please
verify (next branch in my tree).

Thanks.

-- 
Dmitry

linux-next: input tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Hi Dmitry,

Today's linux-next build (powerpc ppc44x_defconfig) failed like this:

drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'

Please at least build test this stuff ...

Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
xilinx_ps2 - use resource_size").

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]