* [patch] generic-ipi: fix backtrace in smp_call_function_any()
@ 2010-01-07 23:46 Suresh Siddha
2010-01-08 4:48 ` David John
0 siblings, 1 reply; 2+ messages in thread
From: Suresh Siddha @ 2010-01-07 23:46 UTC (permalink / raw)
To: Rusty Russell, Thomas Gleixner, H. Peter Anvin, Ingo Molnar; +Cc: LKML
On my westmere box, I see this backtrace with 2.6.33-rc kernels:
> cpumask_of_node(3): node > nr_node_ids(1)
> Pid: 1, comm: swapper Not tainted 2.6.33-rc3-00097-g2c1f189 #223
> Call Trace:
> [<ffffffff81028bb3>] cpumask_of_node+0x23/0x58
> [<ffffffff81061f51>] smp_call_function_any+0x65/0xfa
> [<ffffffff810160d1>] ? do_drv_read+0x0/0x2f
> [<ffffffff81015fba>] get_cur_val+0xb0/0x102
> [<ffffffff81016080>] get_cur_freq_on_cpu+0x74/0xc5
> [<ffffffff810168a7>] acpi_cpufreq_cpu_init+0x417/0x515
> [<ffffffff81562ce9>] ? __down_write+0xb/0xd
> [<ffffffff8148055e>] cpufreq_add_dev+0x278/0x922
fix it by using the cpu_to_node() and using the node number instead
of the cpu for cpumask_of_node().
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
diff --git a/kernel/smp.c b/kernel/smp.c
index de735a6..f104084 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -347,7 +347,7 @@ int smp_call_function_any(const struct cpumask *mask,
goto call;
/* Try for same node. */
- nodemask = cpumask_of_node(cpu);
+ nodemask = cpumask_of_node(cpu_to_node(cpu));
for (cpu = cpumask_first_and(nodemask, mask); cpu < nr_cpu_ids;
cpu = cpumask_next_and(cpu, nodemask, mask)) {
if (cpu_online(cpu))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] generic-ipi: fix backtrace in smp_call_function_any()
2010-01-07 23:46 [patch] generic-ipi: fix backtrace in smp_call_function_any() Suresh Siddha
@ 2010-01-08 4:48 ` David John
0 siblings, 0 replies; 2+ messages in thread
From: David John @ 2010-01-08 4:48 UTC (permalink / raw)
To: Suresh Siddha
Cc: Rusty Russell, Thomas Gleixner, H. Peter Anvin, Ingo Molnar, LKML
On 01/08/2010 05:16 AM, Suresh Siddha wrote:
> On my westmere box, I see this backtrace with 2.6.33-rc kernels:
>
>> cpumask_of_node(3): node > nr_node_ids(1)
>> Pid: 1, comm: swapper Not tainted 2.6.33-rc3-00097-g2c1f189 #223
>> Call Trace:
>> [<ffffffff81028bb3>] cpumask_of_node+0x23/0x58
>> [<ffffffff81061f51>] smp_call_function_any+0x65/0xfa
>> [<ffffffff810160d1>] ? do_drv_read+0x0/0x2f
>> [<ffffffff81015fba>] get_cur_val+0xb0/0x102
>> [<ffffffff81016080>] get_cur_freq_on_cpu+0x74/0xc5
>> [<ffffffff810168a7>] acpi_cpufreq_cpu_init+0x417/0x515
>> [<ffffffff81562ce9>] ? __down_write+0xb/0xd
>> [<ffffffff8148055e>] cpufreq_add_dev+0x278/0x922
>
> fix it by using the cpu_to_node() and using the node number instead
> of the cpu for cpumask_of_node().
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Hi Suresh,
I have already sent a patch for this:
http://www.gossamer-threads.com/lists/linux/kernel/1173978?do=post_view_threaded
Can you ACK that instead?
Regards,
David.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-08 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-07 23:46 [patch] generic-ipi: fix backtrace in smp_call_function_any() Suresh Siddha
2010-01-08 4:48 ` David John
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome