* linux-next: v4l-dvb tree build failure
@ 2010-01-27 6:59 Stephen Rothwell
2010-01-27 23:24 ` Andy Walls
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2010-01-27 6:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel, Devin Heitmueller
Hi Mauro,
Today's linux-next build (powerpc allyesconfig) failed like this:
drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'snd_pcm_alloc_vmalloc_buffer':
drivers/media/video/cx18/cx18-alsa-pcm.c:234: error: implicit declaration of function 'vfree'
drivers/media/video/cx18/cx18-alsa-pcm.c:236: error: implicit declaration of function 'vmalloc'
Caused by commit 5e9a302853301e0a2bb6671036daac3366fd85f4 ("V4L/DVB: cx18: overhaul ALSA PCM device handling so it works").
I applied the following patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 27 Jan 2010 17:53:39 +1100
Subject: [PATCH] V4L/DVB: using vmalloc requires include of linux/vmalloc.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/media/video/cx18/cx18-alsa-pcm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index 6e56df9..b9f42b1 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -25,6 +25,7 @@
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/vmalloc.h>
#include <media/v4l2-device.h>
--
1.6.6
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: v4l-dvb tree build failure
2010-01-27 6:59 linux-next: v4l-dvb tree build failure Stephen Rothwell
@ 2010-01-27 23:24 ` Andy Walls
2010-01-28 1:54 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Andy Walls @ 2010-01-27 23:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mauro Carvalho Chehab, linux-next, linux-kernel, Devin Heitmueller
On Wed, 2010-01-27 at 17:59 +1100, Stephen Rothwell wrote:
> Hi Mauro,
>
> Today's linux-next build (powerpc allyesconfig) failed like this:
>
> drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'snd_pcm_alloc_vmalloc_buffer':
> drivers/media/video/cx18/cx18-alsa-pcm.c:234: error: implicit declaration of function 'vfree'
> drivers/media/video/cx18/cx18-alsa-pcm.c:236: error: implicit declaration of function 'vmalloc'
>
> Caused by commit 5e9a302853301e0a2bb6671036daac3366fd85f4 ("V4L/DVB: cx18: overhaul ALSA PCM device handling so it works").
>
> I applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 27 Jan 2010 17:53:39 +1100
> Subject: [PATCH] V4L/DVB: using vmalloc requires include of linux/vmalloc.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Stephen,
Looks good to me.
Acked-by: Andy Walls <awalls@radix.net>
Regards,
Andy
> ---
> drivers/media/video/cx18/cx18-alsa-pcm.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
> index 6e56df9..b9f42b1 100644
> --- a/drivers/media/video/cx18/cx18-alsa-pcm.c
> +++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
> @@ -25,6 +25,7 @@
>
> #include <linux/init.h>
> #include <linux/kernel.h>
> +#include <linux/vmalloc.h>
>
> #include <media/v4l2-device.h>
>
> --
> 1.6.6
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: v4l-dvb tree build failure
2010-01-27 23:24 ` Andy Walls
@ 2010-01-28 1:54 ` Mauro Carvalho Chehab
2010-01-28 5:24 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2010-01-28 1:54 UTC (permalink / raw)
To: Andy Walls; +Cc: Stephen Rothwell, linux-next, linux-kernel, Devin Heitmueller
Andy Walls wrote:
> On Wed, 2010-01-27 at 17:59 +1100, Stephen Rothwell wrote:
>> Hi Mauro,
>>
>> Today's linux-next build (powerpc allyesconfig) failed like this:
>>
>> drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'snd_pcm_alloc_vmalloc_buffer':
>> drivers/media/video/cx18/cx18-alsa-pcm.c:234: error: implicit declaration of function 'vfree'
>> drivers/media/video/cx18/cx18-alsa-pcm.c:236: error: implicit declaration of function 'vmalloc'
>>
>> Caused by commit 5e9a302853301e0a2bb6671036daac3366fd85f4 ("V4L/DVB: cx18: overhaul ALSA PCM device handling so it works").
>>
>> I applied the following patch for today.
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Wed, 27 Jan 2010 17:53:39 +1100
>> Subject: [PATCH] V4L/DVB: using vmalloc requires include of linux/vmalloc.h
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Stephen,
>
> Looks good to me.
>
> Acked-by: Andy Walls <awalls@radix.net>
Added at the tree.
Cheers,
Mauro.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: v4l-dvb tree build failure
2010-01-28 1:54 ` Mauro Carvalho Chehab
@ 2010-01-28 5:24 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2010-01-28 5:24 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Andy Walls, linux-next, linux-kernel, Devin Heitmueller
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
Hi Mauro, Andy,
On Wed, 27 Jan 2010 23:54:12 -0200 Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
>
> Andy Walls wrote:
> > Looks good to me.
> >
> > Acked-by: Andy Walls <awalls@radix.net>
>
> Added at the tree.
Thanks guys.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-28 5:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-27 6:59 linux-next: v4l-dvb tree build failure Stephen Rothwell
2010-01-27 23:24 ` Andy Walls
2010-01-28 1:54 ` Mauro Carvalho Chehab
2010-01-28 5:24 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®