From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Frans Pop <elendil@planet.nl>
Cc: James Bottomley <James.Bottomley@suse.de>,
joe@perches.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats
Date: Tue, 02 Feb 2010 19:20:28 +0100 [thread overview]
Message-ID: <4B686CEC.4000107@s5r6.in-berlin.de> (raw)
In-Reply-To: <201002011902.33015.elendil@planet.nl>
Frans Pop wrote:
> James Bottomley wrote:
>>> - printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \
>>> - timeout, retry count down = %d \n", acb->host->host_no, retry_count);
>>
>> So I might personally dislike this style
>
> The problem here is not style, but that the whitespace of the indentation
> on the second line becomes part of the output!
> That makes the code defective and is why Joe posted the patch series.
Joe could have pointed this out in the changelog.
s/are not good/incorporate unintended whitespace/
[James wrote:]
>> Why? It's perfectly valid ansi C.
Its syntax is valid but not its semantics.
>> Consider this change veto'd unless you can get an explicit ack from the
>> current maintainer for changing their style.
How about the maintainer takes the fix patch and adjusts style to his
liking? (That's what I would do because I like fix submissions.)
--
Stefan Richter
-=====-==-=- --=- ---=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-02-02 18:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 20:02 [PATCH 00/10] treewide: Fix format strings that misuse continuations Joe Perches
2010-01-31 20:02 ` [PATCH 01/10] arch/powerpc: Fix continuation line formats Joe Perches
2010-02-01 2:16 ` Benjamin Herrenschmidt
2010-02-01 18:30 ` Joe Perches
2010-02-08 3:46 ` Benjamin Herrenschmidt
2010-01-31 20:02 ` [PATCH 02/10] arch/blackfin: " Joe Perches
2010-01-31 20:02 ` [PATCH 03/10] drivers/ide: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 04/10] drivers/serial/bfin_5xx.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 05/10] drivers/scsi/arcmsr: " Joe Perches
2010-02-01 17:16 ` James Bottomley
2010-02-01 17:30 ` Joe Perches
2010-02-01 18:02 ` Frans Pop
2010-02-02 18:20 ` Stefan Richter [this message]
2010-01-31 20:02 ` [PATCH 06/10] drivers/staging: " Joe Perches
2010-01-31 21:22 ` Gábor Stefanik
2010-01-31 20:02 ` [PATCH 07/10] drivers/net/amd8111e.c: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 08/10] fs/proc/array.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 09/10] mm/slab.c: " Joe Perches
2010-01-31 20:08 ` Matt Mackall
2010-01-31 20:13 ` Joe Perches
2010-01-31 20:32 ` Frans Pop
2010-01-31 20:38 ` Joe Perches
2010-01-31 23:53 ` Frans Pop
2010-01-31 20:02 ` [PATCH 10/10] sound/soc/blackfin: " Joe Perches
2010-02-01 14:47 ` Mark Brown
2010-02-01 17:08 ` Joe Perches
2010-02-02 4:13 ` Mike Frysinger
2010-02-02 11:08 ` Mark Brown
2010-02-02 12:55 ` [RFC PATCH] checkpatch.pl: Add warning on non #define continuation lines Joe Perches
2010-02-02 13:49 ` John Kacur
2010-02-02 17:06 ` Mike Frysinger
2010-02-02 22:34 ` [RFC PATCH V2] " Joe Perches
2010-02-02 23:18 ` Daniel Walker
2010-02-03 15:15 ` Andy Whitcroft
[not found] ` <m2n.s.201002011906064544@fjphome.nl>
2010-02-01 19:07 ` [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Frans Pop
2010-02-01 19:35 ` [RFC] Fix unnecessary spaces before newlines in logging messages Joe Perches
2010-02-01 20:10 ` Frans Pop
2010-02-01 20:34 ` [PATCH] Warn on unnecessary spaces before quoted newlines Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B686CEC.4000107@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@suse.de \
--cc=elendil@planet.nl \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome