mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 06/10] drivers/staging: Fix continuation line formats
Date: Sun, 31 Jan 2010 22:22:51 +0100	[thread overview]
Message-ID: <69e28c911001311322v7f3bdd9v4fd2fe85b2e50d1a@mail.gmail.com> (raw)
In-Reply-To: <3ed42b473cd234c42a7c7a0f96f69b5cc4c9d752.1264967499.git.joe@perches.com>

On Sun, Jan 31, 2010 at 9:02 PM, Joe Perches <joe@perches.com> wrote:
> String constants that are continued on subsequent lines with \
> are not good.
> Fixed a "is tryied" / tried typo
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/staging/dream/qdsp5/audio_mp3.c            |    3 +--
>  .../rtl8187se/ieee80211/ieee80211_softmac_wx.c     |    3 +--
>  drivers/staging/rtl8187se/r8180_core.c             |    3 +--
>  drivers/staging/sep/sep_driver.c                   |    3 +--
>  4 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/dream/qdsp5/audio_mp3.c b/drivers/staging/dream/qdsp5/audio_mp3.c
> index b95574f..7ed6e26 100644
> --- a/drivers/staging/dream/qdsp5/audio_mp3.c
> +++ b/drivers/staging/dream/qdsp5/audio_mp3.c
> @@ -650,8 +650,7 @@ static long audio_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>                                                       &audio->read_phys,
>                                                       GFP_KERNEL);
>                                if (!audio->read_data) {
> -                                       pr_err("audio_mp3: malloc pcm \
> -                                       buf failed\n");
> +                                       pr_err("audio_mp3: malloc pcm buf failed\n");
>                                        rc = -1;
>                                } else {
>                                        uint8_t index;
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> index f1d6cb4..ad42bcd 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> @@ -482,8 +482,7 @@ int ieee80211_wx_set_power(struct ieee80211_device *ieee,
>                (!ieee->enter_sleep_state) ||
>                (!ieee->ps_is_queue_empty)){
>
> -               printk("ERROR. PS mode is tryied to be use but\
> -driver missed a callback\n\n");
> +               printk("ERROR. PS mode tried to be use but driver missed a callback\n\n");

This have more typos... "to be use"?

>
>                return -1;
>        }
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index e0f13ef..278992a 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -3864,8 +3864,7 @@ static int __init rtl8180_pci_module_init(void)
>                return ret;
>        }
>
> -       printk(KERN_INFO "\nLinux kernel driver for RTL8180 \
> -/ RTL8185 based WLAN cards\n");
> +       printk(KERN_INFO "\nLinux kernel driver for RTL8180 / RTL8185 based WLAN cards\n");

While you are at it, change this to read RTL8187SE, since RTL8180/85
are not supported by this driver.

>        printk(KERN_INFO "Copyright (c) 2004-2005, Andrea Merello\n");
>        DMESG("Initializing module");
>        DMESG("Wireless extensions version %d", WIRELESS_EXT);
> diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
> index e7bc9ec..8793878 100644
> --- a/drivers/staging/sep/sep_driver.c
> +++ b/drivers/staging/sep/sep_driver.c
> @@ -380,8 +380,7 @@ static int sep_mmap(struct file *filp, struct vm_area_struct *vma)
>           shared area */
>        if ((vma->vm_end - vma->vm_start) > SEP_DRIVER_MMMAP_AREA_SIZE) {
>                edbg("SEP Driver mmap requested size is more than allowed\n");
> -               printk(KERN_WARNING "SEP Driver mmap requested size is more \
> -                       than allowed\n");
> +               printk(KERN_WARNING "SEP Driver mmap requested size is more than allowed\n");
>                printk(KERN_WARNING "SEP Driver vma->vm_end is %08lx\n", vma->vm_end);
>                printk(KERN_WARNING "SEP Driver vma->vm_end is %08lx\n", vma->vm_start);
>                return -EAGAIN;
> --
> 1.6.6.rc0.57.gad7a
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

  reply	other threads:[~2010-01-31 21:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-31 20:02 [PATCH 00/10] treewide: Fix format strings that misuse continuations Joe Perches
2010-01-31 20:02 ` [PATCH 01/10] arch/powerpc: Fix continuation line formats Joe Perches
2010-02-01  2:16   ` Benjamin Herrenschmidt
2010-02-01 18:30     ` Joe Perches
2010-02-08  3:46       ` Benjamin Herrenschmidt
2010-01-31 20:02 ` [PATCH 02/10] arch/blackfin: " Joe Perches
2010-01-31 20:02 ` [PATCH 03/10] drivers/ide: " Joe Perches
2010-02-04  2:44   ` David Miller
2010-01-31 20:02 ` [PATCH 04/10] drivers/serial/bfin_5xx.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 05/10] drivers/scsi/arcmsr: " Joe Perches
2010-02-01 17:16   ` James Bottomley
2010-02-01 17:30     ` Joe Perches
2010-02-01 18:02     ` Frans Pop
2010-02-02 18:20       ` Stefan Richter
2010-01-31 20:02 ` [PATCH 06/10] drivers/staging: " Joe Perches
2010-01-31 21:22   ` Gábor Stefanik [this message]
2010-01-31 20:02 ` [PATCH 07/10] drivers/net/amd8111e.c: " Joe Perches
2010-02-04  2:44   ` David Miller
2010-01-31 20:02 ` [PATCH 08/10] fs/proc/array.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 09/10] mm/slab.c: " Joe Perches
2010-01-31 20:08   ` Matt Mackall
2010-01-31 20:13     ` Joe Perches
2010-01-31 20:32   ` Frans Pop
2010-01-31 20:38     ` Joe Perches
2010-01-31 23:53       ` Frans Pop
2010-01-31 20:02 ` [PATCH 10/10] sound/soc/blackfin: " Joe Perches
2010-02-01 14:47   ` Mark Brown
2010-02-01 17:08     ` Joe Perches
2010-02-02  4:13       ` Mike Frysinger
2010-02-02 11:08         ` Mark Brown
2010-02-02 12:55           ` [RFC PATCH] checkpatch.pl: Add warning on non #define continuation lines Joe Perches
2010-02-02 13:49             ` John Kacur
2010-02-02 17:06               ` Mike Frysinger
2010-02-02 22:34               ` [RFC PATCH V2] " Joe Perches
2010-02-02 23:18                 ` Daniel Walker
2010-02-03 15:15                 ` Andy Whitcroft
     [not found] ` <m2n.s.201002011906064544@fjphome.nl>
2010-02-01 19:07   ` [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Frans Pop
2010-02-01 19:35     ` [RFC] Fix unnecessary spaces before newlines in logging messages Joe Perches
2010-02-01 20:10       ` Frans Pop
2010-02-01 20:34       ` [PATCH] Warn on unnecessary spaces before quoted newlines Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e28c911001311322v7f3bdd9v4fd2fe85b2e50d1a@mail.gmail.com \
    --to=netrolller.3d@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®