FRV: possibly bad unsigned comparison in show

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* FRV: possibly bad unsigned comparison in show_backtrace()
@ 2010-02-08 16:08 Roel Kluin
  2010-02-08 18:43 ` roel kluin
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-02-08 16:08 UTC (permalink / raw)
  To: David Howells, LKML

In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0
then the dump does not succeed because stop was set to 0
and unaltered when we reach the unsigned comparison:

 while (tos < stop) {...}

The naming stop may on the other hand suggest that this
is desired, is it?

Roel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: FRV: possibly bad unsigned comparison in show_backtrace()
  2010-02-08 16:08 FRV: possibly bad unsigned comparison in show_backtrace() Roel Kluin
@ 2010-02-08 18:43 ` roel kluin
  0 siblings, 0 replies; 2+ messages in thread
From: roel kluin @ 2010-02-08 18:43 UTC (permalink / raw)
  To: David Howells, LKML

On Mon, Feb 8, 2010 at 5:08 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
> In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0
> then the dump does not succeed because stop was set to 0
> and unaltered when we reach the unsigned comparison:
>
>  while (tos < stop) {...}

I was mistaken, a while (tos >= stop) won't end

Roel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-08 18:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-08 16:08 FRV: possibly bad unsigned comparison in show_backtrace() Roel Kluin
2010-02-08 18:43 ` roel kluin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®