Re: [PATCH 2/2 V2] io-controller: Document for blkio.weight_device

[Gui Jianfeng <guijianfeng@cn.fujitsu.com>]

Takuya Yoshikawa wrote:
> Hi, I found a typo.
> 
> Gui Jianfeng wrote:
>> +- blkio.weight_device
>> +    - One can specify per cgroup per device rules using this interface.
>> +      These rules override the default value of group weight as
>> specified
>> +      by blkio.weight.
>> +
>> +      Following is the format.
>> +
>> +      #echo dev_maj:dev_minor weight >
>> /patch/to/cgroup/blkio.weight_device
> 
>                                   You mean "path to"?
> 

yeah, will fix.

Thanks
Gui

> Thanks,
>   Takuya
> 
>> +
>> +      weight=0 means removing weight on a given device.
>> +
>> +      Examples:
>> +      Configure weight=300 on /dev/sdb (8:16) in this cgroup
>> +      # echo 8:16 300 > blkio.weight_device
>> +      # cat blkio.weight_device
>> +      dev     weight
>> +      8:16    300
>> +
>> +      Configure weight=500 on /dev/sda (8:0) in this cgroup
>> +      # echo 8:0 500 > blkio.weight_device
>> +      # cat blkio.weight_device
>> +      dev     weight
>> +      8:0     500
>> +      8:16    300
>> +
>> +      Remove specific weight for /dev/sda in this cgroup
>> +      # echo 8:0 0 > blkio.weight_device
>> +      # cat blkio.weight_device
>> +      dev     weight
>> +      8:16    300
>> +
>>  CFQ sysfs tunable
>>  =================
>>  /sys/block/<disk>/queue/iosched/group_isolation
> 
> 
> 
>