From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: tip/master broken with x2apic and kexec
Date: Mon, 12 Jul 2010 23:40:51 -0700 [thread overview]
Message-ID: <4C3C0A73.1090602@zytor.com> (raw)
In-Reply-To: <4C3BDDA3.2060900@kernel.org>
On 07/12/2010 08:29 PM, Yinghai Lu wrote:
>
> offending patch is
>
> commit 83a7a2ad2a9173dcabc05df0f01d1d85b7ba1c2c
> Author: H. Peter Anvin<hpa@linux.intel.com>
> Date: Thu Jun 10 00:10:43 2010 +0000
>
> x86, alternatives: Use 16-bit numbers for cpufeature index
>
> We already have cpufeature indicies above 255, so use a 16-bit number
> for the alternatives index. This consumes a padding field and so
> doesn't add any size, but it means that abusing the padding field to
> create assembly errors on overflow no longer works. We can retain the
> test simply by redirecting it to the .discard section, however.
>
> [ v3: updated to include open-coded locations ]
>
> Signed-off-by: H. Peter Anvin<hpa@linux.intel.com>
> LKML-Reference:<tip-f88731e3068f9d1392ba71cc9f50f035d26a0d4f@git.kernel.org>
> Signed-off-by: H. Peter Anvin<hpa@zytor.com>
>
Oh, good grief, what the hell is wrong with it this time...
-hpa
next prev parent reply other threads:[~2010-07-13 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 2:59 Yinghai Lu
2010-07-13 3:29 ` Yinghai Lu
2010-07-13 6:40 ` H. Peter Anvin [this message]
2010-07-14 0:54 ` [tip:x86/alternatives] x86, alternatives: Fix one more open-coded 8-bit alternative number tip-bot for H. Peter Anvin
2010-07-14 0:54 ` [tip:x86/alternatives] x86, alternatives: BUG on encountering an invalid CPU feature number tip-bot for H. Peter Anvin
2010-07-13 22:00 ` tip/master broken with x2apic and kexec H. Peter Anvin
2010-07-13 23:27 ` Yinghai Lu
2010-07-14 20:35 ` Yinghai Lu
2010-07-14 21:05 ` Don Zickus
2010-07-14 22:07 ` Yinghai Lu
2010-07-14 21:23 ` Yinghai Lu
2010-07-14 22:57 ` Yinghai Lu
2010-07-15 0:03 ` Suresh Siddha
2010-07-15 2:01 ` Yinghai Lu
2010-07-15 7:00 ` [PATCH] x86: fix x2apic preenabled system with kexec Yinghai Lu
2010-07-15 18:16 ` Suresh Siddha
2010-07-15 20:10 ` Yinghai Lu
2010-07-15 20:40 ` Yinghai Lu
2010-07-17 0:48 ` [tip:x86/urgent] x86: Fix " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3C0A73.1090602@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome